diff options
| author | Ken'ichi Ohmichi <oomichi@mxs.nes.nec.co.jp> | 2009-07-06 13:23:44 +0900 |
|---|---|---|
| committer | Dhaval Giani <dhaval@linux.vnet.ibm.com> | 2009-07-07 20:05:21 +0530 |
| commit | 898a4f46a4bc7b75209976b3c2fe6bafd6e2faa0 (patch) | |
| tree | 39ac9e32ab0b3b2975142ddf16082783348b5b30 | |
| parent | a9816059ccbf1d49e86998fb495204d2d7a47309 (diff) | |
| download | libcg-898a4f46a4bc7b75209976b3c2fe6bafd6e2faa0.tar.gz libcg-898a4f46a4bc7b75209976b3c2fe6bafd6e2faa0.tar.xz libcg-898a4f46a4bc7b75209976b3c2fe6bafd6e2faa0.zip | |
Reduce "Cgroup change for PID:X, UID:X, GID:X FAILED!" messages.
Hi,
Changelog since v1:
===================
* Rebase the latest code.
* Cleanup.
The log message "Cgroup change for PID:X, UID:X, GID:X FAILED!" is output
by cgrulesengd daemon, even if a process finished already and that is not
a problem.
This patch prevents the daemon from outputting this spam log message.
* Reference
[PATCH 2/2] Reduce "Cgroup change for PID:X, UID:X, GID:X FAILED!" messages.
http://sourceforge.net/mailarchive/message.php?msg_name=4A10EE7E.60403%40mxs.nes.nec.co.jp
Thanks
Ken'ichi Ohmichi
Signed-off-by: Ken'ichi Ohmichi <oomichi@mxs.nes.nec.co.jp>
Signed-off-by: Dhaval Giani <dhaval@linux.vnet.ibm.com>
| -rw-r--r-- | src/daemon/cgrulesengd.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/src/daemon/cgrulesengd.c b/src/daemon/cgrulesengd.c index 00016e3..38e4f60 100644 --- a/src/daemon/cgrulesengd.c +++ b/src/daemon/cgrulesengd.c @@ -432,11 +432,10 @@ int cgre_process_event(const struct proc_event *ev, const int type) break; } ret = cgre_change_cgroup(euid, egid, procname, pid); - if (ret) { - /* - * TODO: add some supression, do not spam log when every group - * change fails - */ + if ((ret == ECGOTHER) && (errno == ESRCH)) { + /* A process finished already and that is not a problem. */ + ret = 0; + } else if (ret) { flog(LOG_WARNING, "Cgroup change for PID: %d, UID: %d, GID: %d" " FAILED! (Error Code: %d)", log_pid, log_uid, log_gid, ret); |