<feed xmlns='http://www.w3.org/2005/Atom'>
<title>libcg.git/tests, branch devel/config3</title>
<subtitle>Unnamed repository; edit this file to name it for gitweb.</subtitle>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/jsafrane/public_git/libcg.git/'/>
<entry>
<title>Fix compilation outside of source directory</title>
<updated>2009-12-16T08:36:39+00:00</updated>
<author>
<name>Jan Safranek</name>
<email>jsafrane@redhat.com</email>
</author>
<published>2009-12-14T08:22:36+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/jsafrane/public_git/libcg.git/commit/?id=ccf9ad6d879cec4ca7a9620ebe28a53b4568b5d4'/>
<id>ccf9ad6d879cec4ca7a9620ebe28a53b4568b5d4</id>
<content type='text'>
Configure script can be invoked outside of source directory, which allows
to compile sources without spoiling the source directory with compilation
artifacts (like .o files). This patch tries to fix our Makefiles to allow
this to work.

You can test it in current GIT checkout (in the root dir):
# mkdir build; cd build; ../configure; make

As result, you should see all binary files in the 'build' directory.

Signed-off-by: Jan Safranek &lt;jsafrane@redhat.com&gt;
Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Configure script can be invoked outside of source directory, which allows
to compile sources without spoiling the source directory with compilation
artifacts (like .o files). This patch tries to fix our Makefiles to allow
this to work.

You can test it in current GIT checkout (in the root dir):
# mkdir build; cd build; ../configure; make

As result, you should see all binary files in the 'build' directory.

Signed-off-by: Jan Safranek &lt;jsafrane@redhat.com&gt;
Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Enable get_all_controller test</title>
<updated>2009-12-16T08:33:20+00:00</updated>
<author>
<name>Ivana Hutarova Varekova</name>
<email>varekova@redhat.com</email>
</author>
<published>2009-12-10T12:26:11+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/jsafrane/public_git/libcg.git/commit/?id=4fe7821cb82d4866a665c96135c40a662fdf00b8'/>
<id>4fe7821cb82d4866a665c96135c40a662fdf00b8</id>
<content type='text'>
This patch enable get_all_controller test

Signed-off-by: Ivana Hutarova Varekova &lt;varekova@redhat.com&gt;
Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This patch enable get_all_controller test

Signed-off-by: Ivana Hutarova Varekova &lt;varekova@redhat.com&gt;
Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove warnings from test_functions.c</title>
<updated>2009-08-29T05:20:25+00:00</updated>
<author>
<name>Jan Safranek</name>
<email>jsafrane@redhat.com</email>
</author>
<published>2009-08-06T12:03:32+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/jsafrane/public_git/libcg.git/commit/?id=ba948c63f487789e8c3e8478c0edeb15ff716214'/>
<id>ba948c63f487789e8c3e8478c0edeb15ff716214</id>
<content type='text'>
Fix following warnings:
test_functions.c: In function ‘group_modified’:
test_functions.c:435: warning: format ‘%d’ expects type ‘int *’, but argument
3 has type ‘_Bool *’
test_functions.c:440: warning: format ‘%lld’ expects type ‘long long int *’,
but argument 3 has type ‘int64_t *’
test_functions.c:445: warning: format ‘%llu’ expects type ‘long long unsigned
int *’, but argument 3 has type ‘u_int64_t *’

Signed-off-by: Jan Safranek &lt;jsafrane@redhat.com&gt;
Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix following warnings:
test_functions.c: In function ‘group_modified’:
test_functions.c:435: warning: format ‘%d’ expects type ‘int *’, but argument
3 has type ‘_Bool *’
test_functions.c:440: warning: format ‘%lld’ expects type ‘long long int *’,
but argument 3 has type ‘int64_t *’
test_functions.c:445: warning: format ‘%llu’ expects type ‘long long unsigned
int *’, but argument 3 has type ‘u_int64_t *’

Signed-off-by: Jan Safranek &lt;jsafrane@redhat.com&gt;
Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove unnecessary includes from libcgroup.h</title>
<updated>2009-08-29T05:20:25+00:00</updated>
<author>
<name>Jan Safranek</name>
<email>jsafrane@redhat.com</email>
</author>
<published>2009-08-06T12:03:26+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/jsafrane/public_git/libcg.git/commit/?id=6f93cd767947d29c51a8d9fefeb7e582b0a324a2'/>
<id>6f93cd767947d29c51a8d9fefeb7e582b0a324a2</id>
<content type='text'>
libcgroup.h includes some header files, which are not then used. These should
be removed, resp. moved to the source files where they are actually needed.

Signed-off-by: Jan Safranek &lt;jsafrane@redhat.com&gt;
Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
libcgroup.h includes some header files, which are not then used. These should
be removed, resp. moved to the source files where they are actually needed.

Signed-off-by: Jan Safranek &lt;jsafrane@redhat.com&gt;
Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>libcgroup: Use the correct data type in the get_all_controller test case</title>
<updated>2009-08-06T06:33:18+00:00</updated>
<author>
<name>Dhaval Giani</name>
<email>dhaval@linux.vnet.ibm.com</email>
</author>
<published>2009-08-06T06:33:18+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/jsafrane/public_git/libcg.git/commit/?id=0f9535116f2bb200e5d78095aafb22340c449740'/>
<id>0f9535116f2bb200e5d78095aafb22340c449740</id>
<content type='text'>
get_all_controller.c: In function ‘main’:
get_all_controller.c:18: warning: passing argument 1 of ‘cgroup_get_all_controller_begin’ from incompatible pointer type
get_all_controller.c:23: warning: passing argument 1 of ‘cgroup_get_all_controller_next’ from incompatible pointer type
get_all_controller.c:31: warning: passing argument 1 of ‘cgroup_get_all_controller_end’ from incompatible pointer type

The test case used a FILE * instead of a void *. Correct this change (The datatype is opaque to the caller)

Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
get_all_controller.c: In function ‘main’:
get_all_controller.c:18: warning: passing argument 1 of ‘cgroup_get_all_controller_begin’ from incompatible pointer type
get_all_controller.c:23: warning: passing argument 1 of ‘cgroup_get_all_controller_next’ from incompatible pointer type
get_all_controller.c:31: warning: passing argument 1 of ‘cgroup_get_all_controller_end’ from incompatible pointer type

The test case used a FILE * instead of a void *. Correct this change (The datatype is opaque to the caller)

Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Add a new test command "proctest".</title>
<updated>2009-06-29T11:23:21+00:00</updated>
<author>
<name>Ken'ichi Ohmichi</name>
<email>oomichi@mxs.nes.nec.co.jp</email>
</author>
<published>2009-06-26T06:11:16+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/jsafrane/public_git/libcg.git/commit/?id=81dda1ea06a62fb2db52af5c026ae196a2570702'/>
<id>81dda1ea06a62fb2db52af5c026ae196a2570702</id>
<content type='text'>
Hi,

Changelog of v6:
================
 * New patch.

This patch adds a new test command "proctest" for testing both
cgroup_get_uid_gid_from_procfs() and cgroup_get_procname_from_procfs().

 # sleep 100 &amp;
 [1] 28558
 # ./tests/proctest $$ 28558
   Pid  |        Process name              |  Uid  |  Gid
 -------+----------------------------------+-------+-------
  27219 |                        /bin/bash |     0 |     0
  28558 |                       /bin/sleep |     0 |     0
 #

The functions get a process information from /proc fs, and they are
fragile because the content of /proc fs is not stable. If changing
/proc fs in future, this test command will be useful for catching
the change.

Thanks
Ken'ichi Ohmichi

Signed-off-by: Ken'ichi Ohmichi &lt;oomichi@mxs.nes.nec.co.jp&gt;
Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Hi,

Changelog of v6:
================
 * New patch.

This patch adds a new test command "proctest" for testing both
cgroup_get_uid_gid_from_procfs() and cgroup_get_procname_from_procfs().

 # sleep 100 &amp;
 [1] 28558
 # ./tests/proctest $$ 28558
   Pid  |        Process name              |  Uid  |  Gid
 -------+----------------------------------+-------+-------
  27219 |                        /bin/bash |     0 |     0
  28558 |                       /bin/sleep |     0 |     0
 #

The functions get a process information from /proc fs, and they are
fragile because the content of /proc fs is not stable. If changing
/proc fs in future, this test command will be useful for catching
the change.

Thanks
Ken'ichi Ohmichi

Signed-off-by: Ken'ichi Ohmichi &lt;oomichi@mxs.nes.nec.co.jp&gt;
Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>libcgroup: Add get_mount_point test case</title>
<updated>2009-06-26T17:46:22+00:00</updated>
<author>
<name>Dhaval Giani</name>
<email>dhaval@linux.vnet.ibm.com</email>
</author>
<published>2009-06-26T17:46:22+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/jsafrane/public_git/libcg.git/commit/?id=7620ff3e067b8d77ddf321d81b4b19adc2729f6b'/>
<id>7620ff3e067b8d77ddf321d81b4b19adc2729f6b</id>
<content type='text'>
The test case to test the new mount point API.

Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The test case to test the new mount point API.

Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>libcgroup: Introduce an API to get the mount point of a specific subsystem</title>
<updated>2009-06-26T17:36:18+00:00</updated>
<author>
<name>Dhaval Giani</name>
<email>dhaval@linux.vnet.ibm.com</email>
</author>
<published>2009-06-26T17:36:18+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/jsafrane/public_git/libcg.git/commit/?id=305fdb705e4eca50f3dc18d7cc685b547ce0ee98'/>
<id>305fdb705e4eca50f3dc18d7cc685b547ce0ee98</id>
<content type='text'>
Introduce an API which will query the mount table and return the mount point
of a specific subsystem. This is needed in the case when the user knows which
subsystem he wants the details of, which would make the use of the get_controller*
APIs cumbersome.

Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Introduce an API which will query the mount table and return the mount point
of a specific subsystem. This is needed in the case when the user knows which
subsystem he wants the details of, which would make the use of the get_controller*
APIs cumbersome.

Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>libcgroup: Introduce get_controller API</title>
<updated>2009-06-18T14:19:40+00:00</updated>
<author>
<name>Dhaval Giani</name>
<email>dhaval@linux.vnet.ibm.com</email>
</author>
<published>2009-06-18T14:12:48+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/jsafrane/public_git/libcg.git/commit/?id=3ee2b056852a65bc7a3128ef924f1ae83573016e'/>
<id>3ee2b056852a65bc7a3128ef924f1ae83573016e</id>
<content type='text'>
This set of APIs will allow the caller to query the mount table
and find out what controller is mounted at what path.

Test program has been included in the patch. Running the test program
results in

[dhaval@gondor tests]$ ../libtool --mode=execute ./get_controller
Controller cpu is mounted at /cgroup
Controller cpuacct is mounted at /cgroup
Controller memory is mounted at /cgroup1
[dhaval@gondor tests]$

Which is the setup on this system.

Changes from v2
1. Remove the incorrect comments as pointed out by Bharata

Changes from v1
1. Use a new structure as mentioned by bharata to return the values.

Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;
Cc: Jan Safranek &lt;jsafrane@redhat.com&gt;
Acked-by: Bharata B Rao &lt;bharata@linux.vnet.ibm.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This set of APIs will allow the caller to query the mount table
and find out what controller is mounted at what path.

Test program has been included in the patch. Running the test program
results in

[dhaval@gondor tests]$ ../libtool --mode=execute ./get_controller
Controller cpu is mounted at /cgroup
Controller cpuacct is mounted at /cgroup
Controller memory is mounted at /cgroup1
[dhaval@gondor tests]$

Which is the setup on this system.

Changes from v2
1. Remove the incorrect comments as pointed out by Bharata

Changes from v1
1. Use a new structure as mentioned by bharata to return the values.

Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;
Cc: Jan Safranek &lt;jsafrane@redhat.com&gt;
Acked-by: Bharata B Rao &lt;bharata@linux.vnet.ibm.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>libcgroup: Use double pointers everywhere in the get_task APIs</title>
<updated>2009-06-18T14:19:39+00:00</updated>
<author>
<name>Dhaval Giani</name>
<email>dhaval@linux.vnet.ibm.com</email>
</author>
<published>2009-06-18T14:12:47+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/jsafrane/public_git/libcg.git/commit/?id=80e9084d3e7be7fbec1ed72f90b88c7626fb93d1'/>
<id>80e9084d3e7be7fbec1ed72f90b88c7626fb93d1</id>
<content type='text'>
As Jan Safranek pointed out, it is better to have double pointers
everywhere in the get_task API to keep consistency. Do the same.

Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;
Acked-by: Balbir Singh &lt;balbir@linux.vnet.ibm.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
As Jan Safranek pointed out, it is better to have double pointers
everywhere in the get_task API to keep consistency. Do the same.

Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;
Acked-by: Balbir Singh &lt;balbir@linux.vnet.ibm.com&gt;
</pre>
</div>
</content>
</entry>
</feed>
