libcg.git/src/tools, branch master

don't export functions that should not be exported

2010-03-26T11:56:45+00:00

Signed-off-by: Lennart Poettering 
Acked-by: Dhaval Giani 
Signed-off-by: Dhaval Giani

cgget: properly use binary & instead of boolean && when checking for flags

2010-03-26T11:56:44+00:00

Signed-off-by: Lennart Poettering 
Acked-by: Dhaval Giani 
Signed-off-by: Dhaval Giani

add const where applicable, drop const where unnecessary

2010-03-26T11:56:43+00:00

This patch adds the const qualifier to a number of function arguments
(mostly string arguments) so that client libraries can pass their own
const strings to the library without having to cast their const'ness
away.

This also drops a couple of consts where call-by-value is done anyway,
and which hence has no effect and just misleads the users and adds
unnecessary noise to the signal. After all this is C, not C++.

Signed-off-by: Lennart Poettering 
Acked-by: Dhaval Giani 
Signed-off-by: Dhaval Giani

git: hide all generated files from git

2010-03-24T16:06:20+00:00

Signed-off-by: Lennart Poettering 
Reviewed-By: Jan Safranek 
Acked-by: Dhaval Giani 
Signed-off-by: Dhaval Giani

Split header file III

2010-03-21T21:02:01+00:00

Changelog:
 - since there are no global macros, base.h is gone
 - since there is no base.h, all headers need to include  to get
   __BEGIN_DECLS
 - new init.h with cgroup_init() and cgroup_get_subsys_mount_point()
 - new error.h with error handling enum and related stuff
 - use #ifndef _LIBCGROUP_*_H instead _LIBCG_*_H in header guards
 - fix few checkpatch complaints (long lines, whitespaces, ...)

The patch includes Makefile and .spec changes. I tested it compiles,
make dist produces tarball with all headers, so does also the rpm.
'make' should automatically catch all changes in new headers and
recompile dependent (=all) sources when any header changes.

libcgroup.h
  - does not declare anything, it just includes all the other files. In
    future, it might contain base of doxygen documentation (some
    introduction etc.)

libcgroup/error.h
  - the big enum with errors + error related functions

libcgroup/init.h
  - libcgroup_init() and cgroup_get_subsys_mount_point()

libcgroup/config.h
  - configuration reading/unloading

libcgroup/groups.h
  - group manipulation stuff (create/modify/delete/free, incl. controllers and
    get/set values) + definition of struct cgroup (=must be included by
    libcgroup/tasks.h, which needs it)

libcgroup/iterators.h
  - various walks, *_begin/next/end

libcgroup/tasks.h
  - task classification, incl. rules cache manipulation

In addition, I probably removed some #includes, which are not needed now when
looking for the minimal #include set to build the project. I also hope I did not
miss any function declaration or macro...

Signed-off-by: Jan Safranek 
Signed-off-by: Dhaval Giani

Move private definitions to private header

2010-03-21T21:02:01+00:00

Most of the macro definitions in licgroup.h are internal, let's move them
to private header. Applications should not depend on them. The only one
really needed is CG_VALUE_MAX, which is used in struct cgroup_stat.

Signed-off-by: Jan Safranek 
Signed-off-by: Dhaval Giani

Remove GNU_SOURCE from public headers

2010-03-08T14:02:35+00:00

Remove GNU_SOURCE from public headers, it has unpredictable consequences on
applications using libcgroup.h

Signed-off-by: Jan Safranek 
Signed-off-by: Dhaval Giani

fix cgroup_get_value_string problem with *.stat output

2010-02-10T11:13:37+00:00

fix cgroup_get_value_string problem with *.stat output
the problem was in the low limit for value for the output of stat variables - now there are used the functions cgroup_read_stats_{begin/next/end} for this purpose

bogus output:
./src/tools/cgget -r memory.stat /
/:
memory.stat=cache 1024561152
rss 291270656
pgpgin 1209259
pgpgout 888011
inactive_anon 8192
active_anon 2976481

fixed output:
$ ./src/tools/cgget -r memory.stat /
/:
memory.stat=cache 1024610304
	rss 291270656
	pgpgin 1209271
	pgpgout 888011
	inactive_anon 8192
	active_anon 297648128
	inactive_file 619126784
	active_file 399073280
	unevictable 24576
	hierarchical_memory_limit 9223372036854775807
	hierarchical_memsw_limit 9223372036854775807
	total_cache 1024610304
	total_rss 291270656
	total_pgpgin 1209271
	total_pgpgout 888011
	total_inactive_anon 8192
	total_active_anon 297648128
	total_inactive_file 619126784
	total_active_file 399073280
	total_unevictable 24576

Signed-off-by: Ivana Hutarova Varekova 
Signed-off-by: Balbir Singh

This patch adds to cgget option -a:

2010-02-10T11:13:37+00:00

v2:
removed bunch of unnecessary error messages
This patch adds to cgget option -a:
-a     print the variables for all controllers which consists given cgroup

EXAMPLE:
$ ./cgget -a /daemons
/daemons:
cpuset.memory_spread_slab=0
cpuset.memory_spread_page=0
cpuset.memory_pressure=0
cpuset.memory_migrate=0
cpuset.sched_relax_domain_level=-1
cpuset.sched_load_balance=1
cpuset.mem_hardwall=0
cpuset.mem_exclusive=0
cpuset.cpu_exclusive=0
cpuset.mems=
cpuset.cpus=
cpuacct.stat=user 0
system 0
cpuacct.usage_percpu=0 0
cpuacct.usage=0

Signed-off-by: Ivana Hutarova Varekova 
Signed-off-by: Balbir Singh

adds new option -g to cgget command

2010-02-10T11:13:37+00:00

adds new option -g to cgget command
* the option has one argument - controller
* cgget -g devices / returns the values of all variables of controller
devices
* the option could be used multiple times

EXAMLES:

$ ./cgget -n -g cpu -r cpuset.mems /
cpu.rt_period_us=1000000
cpu.rt_runtime_us=950000
cpu.shares=1024
cpuset.mems=0

Signed-off-by: Ivana Hutarova Varekova 
Signed-off-by: Balbir Singh