<feed xmlns='http://www.w3.org/2005/Atom'>
<title>libcg.git, branch fix-initscripts</title>
<subtitle>Unnamed repository; edit this file to name it for gitweb.</subtitle>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/jsafrane/public_git/libcg.git/'/>
<entry>
<title>Move binaries and libraries to /bin and /lib</title>
<updated>2009-03-09T10:44:41+00:00</updated>
<author>
<name>Jan Safranek</name>
<email>jsafrane@redhat.com</email>
</author>
<published>2009-03-09T10:44:41+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/jsafrane/public_git/libcg.git/commit/?id=2d8e15b3541e8bb2ab9573be8cf34951ff61a77e'/>
<id>2d8e15b3541e8bb2ab9573be8cf34951ff61a77e</id>
<content type='text'>
Since cgconfig starts before nfs shares are mounted, it should not use
anything on /usr (it can be on nfs too). All the libcgroup libraries and
binaries should be therefore in /.

Signed-off-by: Jan Safranek &lt;jsafrane@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Since cgconfig starts before nfs shares are mounted, it should not use
anything on /usr (it can be on nfs too). All the libcgroup libraries and
binaries should be therefore in /.

Signed-off-by: Jan Safranek &lt;jsafrane@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Start the config earlier</title>
<updated>2009-03-09T10:44:41+00:00</updated>
<author>
<name>Jan Safranek</name>
<email>jsafrane@redhat.com</email>
</author>
<published>2009-03-09T10:44:41+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/jsafrane/public_git/libcg.git/commit/?id=8114e393c9823380986cfbe57e64875e1506a6ed'/>
<id>8114e393c9823380986cfbe57e64875e1506a6ed</id>
<content type='text'>
We could start cgconfig service earlier, even before network and syslog.
$local_fs is not needed, because /bin, /sbin and /etc are guaranteed by
rc.sysinit (see Fedora bug #309001,
https://bugzilla.redhat.com/show_bug.cgi?id=309001).

Signed-off-by: Jan Safranek &lt;jsafrane@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We could start cgconfig service earlier, even before network and syslog.
$local_fs is not needed, because /bin, /sbin and /etc are guaranteed by
rc.sysinit (see Fedora bug #309001,
https://bugzilla.redhat.com/show_bug.cgi?id=309001).

Signed-off-by: Jan Safranek &lt;jsafrane@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>libcgroup: Initialize buffer in config.c</title>
<updated>2009-03-04T11:38:53+00:00</updated>
<author>
<name>Dhaval Giani</name>
<email>dhaval@linux.vnet.ibm.com</email>
</author>
<published>2009-03-04T11:38:53+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/jsafrane/public_git/libcg.git/commit/?id=a6d564038aa2879e50d01d130d8cc04130e2e555'/>
<id>a6d564038aa2879e50d01d130d8cc04130e2e555</id>
<content type='text'>
Fix the warning,
config.c: In function ‘cgroup_config_parse_controller_options’:
config.c:104: warning: ‘buffer’ may be used uninitialized in this function

Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix the warning,
config.c: In function ‘cgroup_config_parse_controller_options’:
config.c:104: warning: ‘buffer’ may be used uninitialized in this function

Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>libcgroup: Removed unused functions from api.c</title>
<updated>2009-03-04T11:29:49+00:00</updated>
<author>
<name>Dhaval Giani</name>
<email>dhaval@linux.vnet.ibm.com</email>
</author>
<published>2009-03-04T11:29:49+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/jsafrane/public_git/libcg.git/commit/?id=2669880a2f59609269aadde8546385e10b0519d1'/>
<id>2669880a2f59609269aadde8546385e10b0519d1</id>
<content type='text'>
api.c: At top level:
api.c:1780: warning: ‘cg_prepare_controller_array’ defined but not used
api.c:1805: warning: ‘cg_free_controller_array’ defined but not used

Turns out no one is using this functions. Remove them.

Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
api.c: At top level:
api.c:1780: warning: ‘cg_prepare_controller_array’ defined but not used
api.c:1805: warning: ‘cg_free_controller_array’ defined but not used

Turns out no one is using this functions. Remove them.

Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>libcgroup: Fix unused variable warnings for the walk_tree API</title>
<updated>2009-03-04T11:25:35+00:00</updated>
<author>
<name>Dhaval Giani</name>
<email>dhaval@linux.vnet.ibm.com</email>
</author>
<published>2009-03-04T11:25:35+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/jsafrane/public_git/libcg.git/commit/?id=a0012d643c8b2df5506a19a7322fe9cb8321aa3f'/>
<id>a0012d643c8b2df5506a19a7322fe9cb8321aa3f</id>
<content type='text'>
api.c: In function ‘cg_walk_node’:
api.c:2252: warning: unused variable ‘base_level’
api.c: In function ‘cgroup_walk_tree_end’:
api.c:2314: warning: unused variable ‘ret’

Fix the above warnings.

Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;
Cc: Balbir Singh &lt;balbir@linux.vnet.ibm.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
api.c: In function ‘cg_walk_node’:
api.c:2252: warning: unused variable ‘base_level’
api.c: In function ‘cgroup_walk_tree_end’:
api.c:2314: warning: unused variable ‘ret’

Fix the above warnings.

Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;
Cc: Balbir Singh &lt;balbir@linux.vnet.ibm.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>libcgroup: Introduce -Wall in CFLAGS</title>
<updated>2009-03-04T11:22:07+00:00</updated>
<author>
<name>Dhaval Giani</name>
<email>dhaval@linux.vnet.ibm.com</email>
</author>
<published>2009-03-04T11:22:07+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/jsafrane/public_git/libcg.git/commit/?id=496f933b107821504a26cfbe8eac41894ab617a4'/>
<id>496f933b107821504a26cfbe8eac41894ab617a4</id>
<content type='text'>
We did not have -Wall in the CFLAGS and lost out on a number of warnings
because of that. Introduce it now.

Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We did not have -Wall in the CFLAGS and lost out on a number of warnings
because of that. Introduce it now.

Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>libcgroup: Check if the data structures have been initialized for walk_tree</title>
<updated>2009-03-04T09:52:49+00:00</updated>
<author>
<name>Dhaval Giani</name>
<email>dhaval@linux.vnet.ibm.com</email>
</author>
<published>2009-03-03T14:51:03+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/jsafrane/public_git/libcg.git/commit/?id=8594444bf340b98a8d0eb22a4af9c3ce7157d1ba'/>
<id>8594444bf340b98a8d0eb22a4af9c3ce7157d1ba</id>
<content type='text'>
The test for cgroup_init() was not being done by the walk tree APIs.
With this it is possible for it to run without cgroup_init() being
called and having mysterious failures.

Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The test for cgroup_init() was not being done by the walk tree APIs.
With this it is possible for it to run without cgroup_init() being
called and having mysterious failures.

Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>libcgroup: Dont check for success of moved tasks</title>
<updated>2009-03-04T09:52:49+00:00</updated>
<author>
<name>Dhaval Giani</name>
<email>dhaval@linux.vnet.ibm.com</email>
</author>
<published>2009-03-03T14:51:02+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/jsafrane/public_git/libcg.git/commit/?id=19da8166649f449e2762aacdeedcbfefe4ef5c5c'/>
<id>19da8166649f449e2762aacdeedcbfefe4ef5c5c</id>
<content type='text'>
Sometime the movement of tasks in the default cgroup can fail for
various reasons. Therefore, do not check for the success of the
movement of tasks.

Justification: These are generally for cgroups which need some special
setup, for example the RT group scheduler. This is not handled by the
library whihc is generic. If a user is intersted in these working, they
will setup a default cgroup in the config files whihc handle everything
they need.

Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;
Tested-by: Jan Safranek &lt;jsafrane@redhat.com&gt;
Acked-by: Balbir Singh &lt;balbir@linux.vnet.ibm.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Sometime the movement of tasks in the default cgroup can fail for
various reasons. Therefore, do not check for the success of the
movement of tasks.

Justification: These are generally for cgroups which need some special
setup, for example the RT group scheduler. This is not handled by the
library whihc is generic. If a user is intersted in these working, they
will setup a default cgroup in the config files whihc handle everything
they need.

Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;
Tested-by: Jan Safranek &lt;jsafrane@redhat.com&gt;
Acked-by: Balbir Singh &lt;balbir@linux.vnet.ibm.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix a compiling warning</title>
<updated>2009-03-02T10:46:45+00:00</updated>
<author>
<name>Ken'ichi Ohmichi</name>
<email>oomichi@mxs.nes.nec.co.jp</email>
</author>
<published>2009-03-02T06:43:16+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/jsafrane/public_git/libcg.git/commit/?id=2b96be57553709e88783791dee19f353c62fd76e'/>
<id>2b96be57553709e88783791dee19f353c62fd76e</id>
<content type='text'>
This patch fixes the following warning of libcgroup-0.33.

$ make
flex lex.l
byacc -v -d parse.y
byacc: 2 shift/reduce conflicts
cc -g -O2 -I. -shared -fPIC -Wl,--soname,libcgroup.so.1 -o libcgroup.so \
        -Wl,--version-script,libcgroup.map,--allow-shlib-undefined \
        api.c wrapper.c lex.yy.c y.tab.c config.c
lex.l: In function 'yylex':
lex.l:30: warning: incompatible implicit declaration of built-in function 'strdup'
[snip]
$

Signed-off-by: Ken'ichi Ohmichi &lt;oomichi@mxs.nes.nec.co.jp&gt;
Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This patch fixes the following warning of libcgroup-0.33.

$ make
flex lex.l
byacc -v -d parse.y
byacc: 2 shift/reduce conflicts
cc -g -O2 -I. -shared -fPIC -Wl,--soname,libcgroup.so.1 -o libcgroup.so \
        -Wl,--version-script,libcgroup.map,--allow-shlib-undefined \
        api.c wrapper.c lex.yy.c y.tab.c config.c
lex.l: In function 'yylex':
lex.l:30: warning: incompatible implicit declaration of built-in function 'strdup'
[snip]
$

Signed-off-by: Ken'ichi Ohmichi &lt;oomichi@mxs.nes.nec.co.jp&gt;
Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Tag v0.33</title>
<updated>2009-02-28T20:24:28+00:00</updated>
<author>
<name>Dhaval Giani</name>
<email>dhaval@linux.vnet.ibm.com</email>
</author>
<published>2009-02-28T20:24:28+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/jsafrane/public_git/libcg.git/commit/?id=d1c37bf1a840a3a77c7b798fbe50db848ff11520'/>
<id>d1c37bf1a840a3a77c7b798fbe50db848ff11520</id>
<content type='text'>
Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;


git-svn-id: https://libcg.svn.sourceforge.net/svnroot/libcg/tags/v0.33@357 4f4bb910-9a46-0410-90c8-c897d4f1cd53
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Dhaval Giani &lt;dhaval@linux.vnet.ibm.com&gt;


git-svn-id: https://libcg.svn.sourceforge.net/svnroot/libcg/tags/v0.33@357 4f4bb910-9a46-0410-90c8-c897d4f1cd53
</pre>
</div>
</content>
</entry>
</feed>
