| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
| |
Hopefully there is no major roadblock making this change unreasonable at
this point in time (checked commonly used RHEL, Fedora, Debian/Ubuntu
-- the latter also for seamless integration with Travis CI).
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
|
|
|
|
| |
See, e.g.,
https://git.fedorahosted.org/cgit/cluster.git/commit/?h=STABLE32&id=5bddd1e21098a183560f64a569dd15fa8fdca1a8
https://bugzilla.redhat.com/show_bug.cgi?id=707118#c9
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
|
|
|
| |
... as this is the most suitable moment (we will not be parsing
resource rules/metadata later again).
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
|
|
| |
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1201290
Reported-by: Patrik Hagara <phagara@redhat.com>
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
|
|
|
| |
When we are not sure about how to run samba on the target system, simply
assume service:samba.
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
|
|
| |
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1201278
Reported-by: Patrik Hagara <phagara@redhat.com>
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
|
|
|
|
|
|
| |
Hence hard-code the distro to the testing command to make sure it
reproduces what the hardwired referential results where obtained with.
Check, e.g., this commit to learn about what I mean:
filters/ccsflat2cibprelude[clusternode]: conditional node id.
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Originally, the intended decision point couldn't be reached due to
logical exclusion by the parent condition. Beside fixing that,
also rearrange the order of sibling choices so as to better reflect
the intended logic.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1206585
Reported-by: Patrik Hagara <phagara@redhat.com>
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
...by removing extraneous xsl:attribute closing tag, adding missing
closing brace in test expression of xsl:when, and reindenting the whole
XLS snippet.
(FWIW, previously wasn't the branching based on system/distro working
correctly, until recent commit:
filter: inject virtual "just merge, preserve-rest" abs. parent)
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1208128
Reported-by: Patrik Hagara <phagara@redhat.com>
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
...by adding missed xsl:choose closing tag.
(FWIW, previously wasn't the branching based on system/distro working
correctly, until recent commit:
filter: inject virtual "just merge, preserve-rest" abs. parent)
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1208133
Reported-by: Patrik Hagara <phagara@redhat.com>
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
|
| |
Resolves: rhbz#1207345
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is needed so as to spread top level XSLT tags from implicit
def_first ($system{,_1,_2} params, etc.).
(Alternatively, we could somehow propagate the parameters Python-wise
and then passed them to respective method:
http://lxml.de/xpathxslt.html#stylesheet-parameters
but this seems bit more systemic [although clunky])
Related: rhbz#1207345
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Q: performing the check upon option parsing means this check is not
performed for both the default value and when clufter used as a lib
A: mocking some arguments to the callback will make it universal
(alternatively, refactorization, etc.)
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
|
|
| |
(preparation work)
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
|
|
|
| |
(headbang: this is what the conversion templates already rely upon,
i.e., on "linux", not "Linux", which is what platform.system returns)
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
|
|
| |
"pcs" should be reserved for actual pcs CLI tool commands.
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
|
|
|
|
|
| |
We hadn't been going up enough (from '/etc/init.d/').
Still thinking about a better solution, though.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1201297
Reported-by: Patrik Hagara <phagara@redhat.com>
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
|
|
|
|
| |
... to prevent word splitting
(marked suspicious by ShellCheck tool)
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
|
|
| |
(marked suspicious by ShellCheck tool)
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
|
|
|
| |
... that also makes this wrapped iteration more-or-less compatible with
list_remove (see the in-line comment, but discretion needed, untested!)
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
list_do: do not check *list twice
list_done: do not check curr, as we are quite sure it will never reach
NULL value implicitly (using intended list manipulators incl.
the wrapped iteration itself, not explicit redefinition that
is broken anyway), otherwise we would have already observed
either trivial infloops or segfaults caused by reliance on
such an assumption (curr != NULL)
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
|
|
| |
Also drop unnecessary assert.h include from xmlconf.c
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
|
|
| |
(code marked suspicious by static analysis)
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
|
|
| |
(found by static analysis)
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
|
|
| |
(finding of static analysis)
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Problem is in "params in system-wide sysconfig file" (rgmanager RA) vs.
"params properly tracked as cluster config" (heartbeat RA).
Could be extended to actually read the referred file, but that is quite
unreliable (existence of that file cannot be assumed in various
scenarios).
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1201317
Reported-by: Patrik Hagara <phagara@redhat.com>
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
|
|
| |
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1201282
Reported-by: Patrik Hagara <phagara@redhat.com>
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
|
|
|
|
| |
Promised "more systemic/less error-prone solution" to prevent random
mistakes/typos/inconsistencies and to exercise DRY principle (slash
common sense).
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
|
|
|
| |
(Clearly a sign more systemic/less error-prone solution needed, in the
works...)
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
|
|
| |
Using "operations" provision (akin to apache/@shutdown_wait).
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
|
| |
Reported-by: Patrik Hagara <phagara@redhat.com>
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Parameter added to rgmanager's RA as of
https://bugzilla.redhat.com/show_bug.cgi?id=918315
and heartbeat's RA as of
https://bugzilla.redhat.com/show_bug.cgi?id=1096376
https://bugzilla.redhat.com/show_bug.cgi?id=1096377
Reported-by: Patrik Hagara <phagara@redhat.com>
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
|
|
|
| |
(Also fix a minor s/nfserver/nfsserver/ typo.)
Reported-by: Patrik Hagara <phagara@redhat.com>
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
|
|
|
| |
See
https://docs.python.org/2/library/subprocess.html#subprocess.Popen.returncode
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|