summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* facts: overload/extend aliases_dist mapping (vol.2)Jan Pokorný2015-10-081-3/+6
| | | | Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* facts: update cluster_map with RHEL 6.7/7.2 infoJan Pokorný2015-10-081-0/+6
| | | | Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* commands/cib2pcscmd: deploy (forgotten) cmd-wrap filterJan Pokorný2015-10-081-2/+5
| | | | Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* run-check: --dist goes prior alias cmd to influence itJan Pokorný2015-10-081-4/+4
| | | | | | | | | | | | | | | | This hasn't been considered before (hence the bug being fixed), and it seems best if --dist in "global options" (prior to cmd spec) is the only to influence command alias resolution, whereas --dist as "command option" can influence some specifics for the command itself. This way, natural causality on the command line is preserved. Alternatively, we could look-ahead if there is dist defined as command option and considered it in the alias resolution. But rather than that, it would more bearable to remove --dist/--sys from command options altogether but that would prevent injecting them when command-by-symlink is exercised, so do not do this either. Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* Set pre-release versionJan Pokorný2015-10-082-2/+5
| | | | Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* Bump version to 0.50.4v0.50.4Jan Pokorný2015-09-092-2/+2
| | | | Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* run-check: add a (sanity) check for ccs2pcscmd outputJan Pokorný2015-09-091-1/+77
| | | | Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* run-check: we can rely on dist-implied alias resolutionJan Pokorný2015-09-091-2/+2
| | | | Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* filters/cib2pcscmd[configuration]: never start with empty CIBJan Pokorný2015-09-091-0/+11
| | | | | | See <https://bugzilla.redhat.com/1230368>. Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* ccs-flatten: fix possible memleakJan Pokorný2015-09-091-18/+25
| | | | | | | | | | | | | | | | | | | | | | | | | ...found by static analysis Account for simplistic logic of the call site (our goal is not "read as many bytes as you can, stop on first allocation error, but be fine with what was read so far, if any" -- that is not intended when you need to read whole parseable XML). There are more considerations: - realloc(p, 0) may or may not free p, one shouldn't free it manually to prevent double-free (do I understand "man 3p realloc" right?) - length (size_t) can overflow, leading realloc to actually decrease the allocated memory, perhaps even to zero, i.e., possible free as mentioned above) - realloc(NULL, size) == malloc(size) - check in "if (x) free(x);" is redundant - if read_pipe returns OK, we can now safely assume: size > 0 Also following principles are followed: - there should be just one cleanup on error - notable code branches and otherwise silent assumptions commented upon Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* ccs-flatten/resrules.c: fix errno.h include in wrong filEJan Pokorný2015-09-092-1/+1
| | | | Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* Set pre-release versionJan Pokorný2015-09-092-2/+5
| | | | Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* Bump version to 0.50.3v0.50.3Jan Pokorný2015-09-022-3/+3
| | | | Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* filters/ccsflat2cibprelude[SAPInstance]: "convert", finallyJan Pokorný2015-09-023-0/+76
| | | | Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* filters/ccsflat2cibprelude[SAPDatabase]: "convert", finallyJan Pokorný2015-09-023-0/+101
| | | | | | Also add the unit test(s). Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* tests: cosmetics/styleJan Pokorný2015-09-022-2/+2
| | | | Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* utils_cib: also support deprecated params in rg2hb_xslJan Pokorný2015-09-021-6/+12
| | | | Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* filters/needlexml2pcscmd[interface]: fix invalid XMLJan Pokorný2015-09-021-2/+2
| | | | Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* filters/ccsflat2cibprelude[rm]: use knowledge of primary attrJan Pokorný2015-09-021-2/+7
| | | | Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* ccs-flatten: inject also primary attribute nameJan Pokorný2015-09-023-0/+22
| | | | Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* ccs-flatten: remove metadata for long deprecated tomcat-5 RAJan Pokorný2015-09-021-104/+0
| | | | | | See <https://bugzilla.redhat.com/show_bug.cgi?id=593721>. Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* ccs-flatten: accidentally omitted SAP{Database,Instance} metadataJan Pokorný2015-09-022-0/+171
| | | | Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* ccs-flatten/Makefile: agents do not always have trailing .shJan Pokorný2015-09-021-2/+4
| | | | | | Cf. SAP{Database,Instance}. Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* clufter.spec: prepare grounds for possible pagure.io jumpJan Pokorný2015-09-022-7/+12
| | | | | | Open source infrastructure FTW! Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* travis: irc notifications for #clusterlabs-dev @ freenodeJan Pokorný2015-09-021-0/+3
| | | | | | Cf. http://clusterlabs.org/pipermail/users/2015-June/000576.html Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* Set pre-release versionJan Pokorný2015-09-022-2/+5
| | | | Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* Bump version to 0.50.2v0.50.2Jan Pokorný2015-08-112-3/+3
| | | | Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* filters/ccsflat2cibprelude[nfsclient]: forgotten RA conversionJan Pokorný2015-08-112-0/+128
| | | | | | | Also included are respective unit tests (that needed code adjustments and fixtures spanning several past commits). Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* plugin_registry: more systemic builtin plugin paths injectionJan Pokorný2015-08-111-8/+7
| | | | | | | Now, the injection can be prevented by either specifying paths as None or by initial item in the non-empty iterable being None. Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* filter: when filter validates along, avoid revalidationJan Pokorný2015-08-111-1/+4
| | | | | | ... on output format instantiation (needless and unhelpful). Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* filter: XMLFilter.deco_xslt's fnc can be parametrized directlyJan Pokorný2015-08-111-2/+4
| | | | | | In that case, these directly passed kwargs take the precedence. Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* filter: allow passing xml_root into Format's walk_schemaJan Pokorný2015-08-111-3/+6
| | | | Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* format: cosmetics/indentationJan Pokorný2015-08-111-1/+1
| | | | Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* format: walk_schema now allows overriding of xml_rootJan Pokorný2015-08-111-2/+2
| | | | Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* format: Format/walk_schema inconsistency robustness++Jan Pokorný2015-08-111-3/+7
| | | | | | | | | Properly report an inconsistency, such as when nothing corresponding to xml_root is found under root_dir directory, making the walk tree empty. Also turn a following INFLOOP exception into a dedicated Format one. Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* format: turn validator from classmethod to hybridmethodJan Pokorný2015-08-111-5/+6
| | | | Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* utils: new "hybridmethod" decoratorJan Pokorný2015-08-111-0/+8
| | | | | | | | | | | Similar to hybridproperty: first parameter of the decorated method is flexibly bound to either the instance or the class depending on the context of invokation. Effectively, the only difference is that hybridmethod is expected to be passed arguments, unlike with property where it is called directly (w/o parameters) upon access. Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* tests: spin off TeardownFilterTestCase classJan Pokorný2015-08-111-4/+6
| | | | | | Likewise, this a "ground preparation" for upcoming new unit test. Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* tests/_common.py, import -> tests/_com, execfileJan Pokorný2015-08-112-3/+3
| | | | | | | Preparing ground for nested test and unittest not playing well with symlinked _common.py in such the respective nested directory. Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* tests/formats/command: avoid a needless warningJan Pokorný2015-08-111-2/+4
| | | | | | | > WARNING:clufter.formats.command:'command' format: not backed by > OrderedDict Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* filters/cib2pcscmd[resources]: stonith also handles meta attrs/opsJan Pokorný2015-08-111-0/+19
| | | | | | See https://bugzilla.redhat.com/show_bug.cgi?id=1225946. Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* filters/cib2pcscmd[resources]: warn on rule-based "attribute sets"Jan Pokorný2015-08-112-15/+34
| | | | | | In a wait for https://bugzilla.redhat.com/show_bug.cgi?id=1250744. Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* utils: try avoiding clash of special keys in kwargsJan Pokorný2015-08-112-8/+8
| | | | | | | | ...in filterdict_* lambdas where (now) _fn_ is a special key. Also adjust the callers where needed. Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* filters/cibprelude2cibcompact[resources]: fix rule+stickinessJan Pokorný2015-08-112-2/+6
| | | | | | | | | Apparently, rule is supposed to accompany the actual nvpair that will be applied in case such condition holds (otherwise it's a no-op). Adjust a check script respectively. Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* Set pre-release versionJan Pokorný2015-08-112-2/+5
| | | | Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* Bump version to 0.50.1v0.50.1Jan Pokorný2015-07-142-3/+3
| | | | Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* setup: include "void"/minimal format instances (files)Jan Pokorný2015-07-141-0/+1
| | | | Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* format: add optional knowledge of a "void"/minimal fileJan Pokorný2015-07-143-0/+23
| | | | Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* format: avoid duplicate "swallow" (+validation, ...)Jan Pokorný2015-07-141-1/+2
| | | | | | | Also fixes assertion error for two equal (but non-identical) tuples later on. Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
* commands/pcs2pcscmd: fix a (dire) filter swapJan Pokorný2015-07-141-2/+2
| | | | Signed-off-by: Jan Pokorný <jpokorny@redhat.com>