From d73f8a53dd280da10640f51a85d8eef4ce8f8946 Mon Sep 17 00:00:00 2001 From: Simo Sorce Date: Wed, 19 Dec 2012 08:48:06 -0500 Subject: sssd_nss: Plug memory leaks A recent patch introduced a glaring memory leak in the routines that clean up memcache memory on initgroups calls. --- src/responder/nss/nsssrv_cmd.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/responder/nss/nsssrv_cmd.c b/src/responder/nss/nsssrv_cmd.c index 58d8afab5..22eba5127 100644 --- a/src/responder/nss/nsssrv_cmd.c +++ b/src/responder/nss/nsssrv_cmd.c @@ -154,6 +154,8 @@ void nss_update_pw_memcache(struct nss_ctx *nctx) ret, strerror(ret))); } } + + talloc_zfree(res); } } @@ -1853,6 +1855,7 @@ void nss_update_gr_memcache(struct nss_ctx *nctx) ret, strerror(ret))); } } + talloc_zfree(res); } } @@ -3368,6 +3371,7 @@ void nss_update_initgr_memcache(struct nss_ctx *nctx, const char *name, const char *domain, int gnum, uint32_t *groups) { + TALLOC_CTX *tmp_ctx = NULL; struct sss_domain_info *dom; struct ldb_result *res; bool changed = false; @@ -3393,12 +3397,14 @@ void nss_update_initgr_memcache(struct nss_ctx *nctx, return; } - ret = sysdb_initgroups(NULL, dom->sysdb, name, &res); + tmp_ctx = talloc_new(NULL); + + ret = sysdb_initgroups(tmp_ctx, dom->sysdb, name, &res); if (ret != EOK && ret != ENOENT) { DEBUG(SSSDBG_CRIT_FAILURE, ("Failed to make request to our cache! [%d][%s]\n", ret, strerror(ret))); - return; + goto done; } /* copy, we need the original intact in case we need to invalidate @@ -3453,6 +3459,9 @@ void nss_update_initgr_memcache(struct nss_ctx *nctx, } } } + +done: + talloc_free(tmp_ctx); } /* FIXME: what about mpg, should we return the user's GID ? */ -- cgit