From c5290f2175845f2c5e3f35ce279b6f52b1d51275 Mon Sep 17 00:00:00 2001 From: Pavel Reichl Date: Wed, 25 Feb 2015 05:38:38 -0500 Subject: PAM: check return value of confdb_get_string Coverity found this neglect. Reviewed-by: Jakub Hrozek --- src/responder/pam/pamsrv_cmd.c | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'src') diff --git a/src/responder/pam/pamsrv_cmd.c b/src/responder/pam/pamsrv_cmd.c index 2ce61881f..d0e7327d8 100644 --- a/src/responder/pam/pamsrv_cmd.c +++ b/src/responder/pam/pamsrv_cmd.c @@ -680,6 +680,12 @@ static void pam_reply(struct pam_auth_req *preq) ret = confdb_get_string(pctx->rctx->cdb, pd, CONFDB_PAM_CONF_ENTRY, CONFDB_PAM_ACCOUNT_EXPIRED_MESSAGE, "", &pam_account_expired_message); + if (ret != EOK) { + DEBUG(SSSDBG_MINOR_FAILURE, + "Failed to get expiration message: %d:[%s].\n", + ret, sss_strerror(ret)); + goto done; + } inform_account_expired(pd, pam_account_expired_message); } -- cgit