From 2dae2ae732b0c8e31fd1d8dc38f207c62e7665b8 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Thu, 10 Oct 2013 19:21:07 +0200 Subject: LDAP: Delete entry by SID if not found In case the entry was deleted from the server, the search didn't notice and kept returning the cached data. --- src/providers/ldap/ldap_id.c | 22 +++++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-) (limited to 'src') diff --git a/src/providers/ldap/ldap_id.c b/src/providers/ldap/ldap_id.c index 9fd95ce79..624533301 100644 --- a/src/providers/ldap/ldap_id.c +++ b/src/providers/ldap/ldap_id.c @@ -1553,12 +1553,28 @@ static void get_user_and_group_users_done(struct tevent_req *subreq) ret = users_get_recv(subreq, &state->dp_error, &state->sdap_ret); talloc_zfree(subreq); - if (ret == EOK) { /* Matching user found */ - tevent_req_done(req); - } else { + if (ret != EOK) { tevent_req_error(req, ret); + return; } + if (state->sdap_ret == ENOENT) { + /* The search ran to completion, but nothing was found. + * Delete the existing entry, if any. */ + ret = sysdb_delete_by_sid(state->sysdb, state->domain, + state->filter_val); + if (ret != EOK) { + DEBUG(SSSDBG_OP_FAILURE, ("Could not delete entry by SID!\n")); + tevent_req_error(req, ret); + return; + } + } else if (state->sdap_ret != EOK) { + tevent_req_error(req, EIO); + return; + } + + /* Both ret and sdap->ret are EOK. Matching user found */ + tevent_req_done(req); return; } -- cgit