From 7215ce30acdc19e95e31d83518a20f75eec74112 Mon Sep 17 00:00:00 2001 From: Stephen Gallagher Date: Thu, 16 Dec 2010 14:39:00 -0500 Subject: Fix unchecked return value in sss_krb5_verify_keytab_ex https://fedorahosted.org/sssd/ticket/711 --- src/util/sss_krb5.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) (limited to 'src/util/sss_krb5.c') diff --git a/src/util/sss_krb5.c b/src/util/sss_krb5.c index 174b6d9fa..894dd443d 100644 --- a/src/util/sss_krb5.c +++ b/src/util/sss_krb5.c @@ -152,7 +152,14 @@ int sss_krb5_verify_keytab_ex(const char *principal, const char *keytab_name, found = true; } free(kt_principal); - krb5_free_keytab_entry_contents(context, &entry); + krberr = krb5_free_keytab_entry_contents(context, &entry); + if (krberr) { + /* This should never happen. The API docs for this function + * specify only success for this function + */ + DEBUG(1,("Could not free keytab entry contents\n")); + /* This is non-fatal, so we'll continue here */ + } if (found) { break; -- cgit