From 3242dd4a49c3869c9b066a63afb81cebf1a35b7d Mon Sep 17 00:00:00 2001
From: Simo Sorce <simo@redhat.com>
Date: Sat, 9 Nov 2013 16:07:06 -0500
Subject: Signals: Refactor termination of processes

sig_term() was never used as a real signal handler, but only called by tevent
signal handlers in the kerberos and ldap children.
Also the same code was duplicated with separate local guard variables in other
functions.
Unify orderly termination handling, between all these functions.
---
 src/util/server.c | 36 ++++++++++--------------------------
 1 file changed, 10 insertions(+), 26 deletions(-)

(limited to 'src/util/server.c')

diff --git a/src/util/server.c b/src/util/server.c
index 11569b937..b2fad1168 100644
--- a/src/util/server.c
+++ b/src/util/server.c
@@ -237,18 +237,18 @@ int pidfile(const char *path, const char *name)
     return 0;
 }
 
-void sig_term(int sig)
+void orderly_shutdown(int status)
 {
 #if HAVE_GETPGRP
-    static int done_sigterm;
-    if (done_sigterm == 0 && getpgrp() == getpid()) {
+    static int sent_sigterm;
+    if (sent_sigterm == 0 && getpgrp() == getpid()) {
         DEBUG(SSSDBG_FATAL_FAILURE, ("SIGTERM: killing children\n"));
-        done_sigterm = 1;
+        sent_sigterm = 1;
         kill(-getpgrp(), SIGTERM);
     }
 #endif
-    sss_log(SSS_LOG_INFO, "Shutting down");
-    exit(0);
+    if (status == 0) sss_log(SSS_LOG_INFO, "Shutting down");
+    exit(status);
 }
 
 static void default_quit(struct tevent_context *ev,
@@ -258,31 +258,15 @@ static void default_quit(struct tevent_context *ev,
                          void *siginfo,
                          void *private_data)
 {
-#if HAVE_GETPGRP
-    static int done_sigterm;
-    if (done_sigterm == 0 && getpgrp() == getpid()) {
-        DEBUG(SSSDBG_FATAL_FAILURE, ("SIGTERM: killing children\n"));
-        done_sigterm = 1;
-        kill(-getpgrp(), SIGTERM);
-    }
-#endif
-    sss_log(SSS_LOG_INFO, "Shutting down");
-    exit(0);
+    orderly_shutdown(0);
 }
 
 #ifndef HAVE_PRCTL
 static void sig_segv_abrt(int sig)
 {
-#if HAVE_GETPGRP
-    static int done;
-    if (done == 0 && getpgrp() == getpid()) {
-        DEBUG(SSSDBG_FATAL_FAILURE, ("%s: killing children\n",
-                                     strsignal(sig)));
-        done = 1;
-        kill(-getpgrp(), SIGTERM);
-    }
-#endif  /* HAVE_GETPGRP */
-    exit(1);
+    DEBUG(SSSDBG_FATAL_FAILURE,
+          ("Received signal %s, shutting down\n", strsignal(sig)));
+    orderly_shutdown(1);
 }
 #endif /* HAVE_PRCTL */
 
-- 
cgit