From fb0332565892bc10998ca98b567d4dde2213844d Mon Sep 17 00:00:00 2001 From: Nikolai Kondrashov Date: Thu, 10 Oct 2013 13:16:36 +0300 Subject: Move DEBUG macro body to debug_fn Move DEBUG macro body to the debug_fn function, adding "function" argument to the latter. Rename "debug_fn" in sssd_krb5_locator_plugin.c to "plugin_debug_fn" to remove conflict with the sssd debug_fn. Replace DEBUG_MSG macro usage with debug_fn function usage. Remove DEBUG_MSG macro along with tests. The above makes the total size of binaries drop by 20% for the standard Fedora build and by 44% for a build configured according to Debian packaging script. Reviewed-by: Jakub Hrozek Reviewed-by: Stephen Gallagher Reviewed-by: Simo Sorce --- src/util/debug.c | 50 ++++++++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 46 insertions(+), 4 deletions(-) (limited to 'src/util/debug.c') diff --git a/src/util/debug.c b/src/util/debug.c index 324f0daeb..91a030f2c 100644 --- a/src/util/debug.c +++ b/src/util/debug.c @@ -104,18 +104,59 @@ int debug_convert_old_level(int old_level) return new_level; } -void debug_fn(const char *format, ...) +static void debug_vprintf(const char *format, va_list ap) +{ + vfprintf(debug_file ? debug_file : stderr, format, ap); + fflush(debug_file ? debug_file : stderr); +} + +static void debug_printf(const char *format, ...) + SSS_ATTRIBUTE_PRINTF(1, 2); + +static void debug_printf(const char *format, ...) { va_list ap; va_start(ap, format); - vfprintf(debug_file ? debug_file : stderr, format, ap); - fflush(debug_file ? debug_file : stderr); + debug_vprintf(format, ap); va_end(ap); } +void debug_fn(const char *function, int newlevel, const char *format, ...) +{ + va_list ap; + if (debug_timestamps) { + struct timeval tv; + struct tm *tm; + char datetime[20]; + int year; + gettimeofday(&tv, NULL); + tm = localtime(&tv.tv_sec); + year = tm->tm_year + 1900; + /* get date time without year */ + memcpy(datetime, ctime(&tv.tv_sec), 19); + datetime[19] = '\0'; + if (debug_microseconds) { + debug_printf("(%s:%.6ld %d) [%s] [%s] (%#.4x): ", + datetime, tv.tv_usec, + year, debug_prg_name, + function, newlevel); + } else { + debug_printf("(%s %d) [%s] [%s] (%#.4x): ", + datetime, year, + debug_prg_name, function, newlevel); + } + } else { + debug_printf("[%s] [%s] (%#.4x): ", + debug_prg_name, function, newlevel); + } + va_start(ap, format); + debug_vprintf(format, ap); + va_end(ap); +} + int debug_get_level(int old_level) { if ((old_level != 0) && !(old_level & 0x000F)) @@ -168,7 +209,8 @@ void ldb_debug_messages(void *context, enum ldb_debug_level level, return; } - DEBUG_MSG(loglevel, "ldb", message); + if (DEBUG_IS_SET(loglevel)) + debug_fn("ldb", loglevel, "%s\n", message); free(message); } -- cgit