From 441c0f5e1e05db77c62f3281525345ff322b0a65 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Fri, 7 Mar 2014 09:26:22 +0100 Subject: PAM: Test return value of strdup Warnings reported by Coverity (12463,12464) Dereferencing a pointer that might be null pi->pam_authtok when calling strlen. Dereferencing a pointer that might be null action when calling strncmp. Reviewed-by: Stephen Gallagher --- src/sss_client/pam_test_client.c | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'src/sss_client/pam_test_client.c') diff --git a/src/sss_client/pam_test_client.c b/src/sss_client/pam_test_client.c index ef424e77c..af8a0da90 100644 --- a/src/sss_client/pam_test_client.c +++ b/src/sss_client/pam_test_client.c @@ -53,6 +53,11 @@ int main(int argc, char *argv[]) { user = strdup(argv[2]); } + if (action == NULL || user == NULL) { + fprintf(stderr, "Out of memory!\n"); + return 1; + } + fprintf(stdout, "action: %s\nuser: %s\n", action,user); ret = pam_start("sss_test", user, &conv, &pamh); -- cgit