From 24d319721a43101d996034442137bae37b007fd3 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Tue, 15 Feb 2011 14:16:13 +0100 Subject: Fix unchecked return values of pam_add_response https://fedorahosted.org/sssd/ticket/798 --- src/responder/pam/pamsrv_cmd.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) (limited to 'src/responder/pam/pamsrv_cmd.c') diff --git a/src/responder/pam/pamsrv_cmd.c b/src/responder/pam/pamsrv_cmd.c index 8035a6878..3c9d7600a 100644 --- a/src/responder/pam/pamsrv_cmd.c +++ b/src/responder/pam/pamsrv_cmd.c @@ -500,8 +500,12 @@ static void pam_reply(struct pam_auth_req *preq) DEBUG(5, ("Password change not possible while offline.\n")); pd->pam_status = PAM_AUTHTOK_ERR; user_info_type = SSS_PAM_USER_INFO_OFFLINE_CHPASS; - pam_add_response(pd, SSS_PAM_USER_INFO, sizeof(uint32_t), - (const uint8_t *) &user_info_type); + ret = pam_add_response(pd, SSS_PAM_USER_INFO, sizeof(uint32_t), + (const uint8_t *) &user_info_type); + if (ret != EOK) { + DEBUG(1, ("pam_add_response failed.\n")); + goto done; + } break; /* TODO: we need the pam session cookie here to make sure that cached * authentication was successful */ @@ -565,8 +569,12 @@ static void pam_reply(struct pam_auth_req *preq) } if (pd->domain != NULL) { - pam_add_response(pd, SSS_PAM_DOMAIN_NAME, strlen(pd->domain)+1, - (uint8_t *) pd->domain); + ret = pam_add_response(pd, SSS_PAM_DOMAIN_NAME, strlen(pd->domain)+1, + (uint8_t *) pd->domain); + if (ret != EOK) { + DEBUG(1, ("pam_add_response failed.\n")); + goto done; + } } resp_c = 0; -- cgit