From 7486dea9f5f7b2a6fbbacc6db740a82140b6377c Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Fri, 17 May 2013 17:36:38 +0200 Subject: Fixing critical format string issues. --missing arguments. --format '%s', but argument is integer. --wrong format string, examle: '%\n' --- src/responder/nss/nsssrv_cmd.c | 15 ++++++++++----- src/responder/nss/nsssrv_services.c | 2 +- 2 files changed, 11 insertions(+), 6 deletions(-) (limited to 'src/responder/nss') diff --git a/src/responder/nss/nsssrv_cmd.c b/src/responder/nss/nsssrv_cmd.c index c409e7947..57b5786f3 100644 --- a/src/responder/nss/nsssrv_cmd.c +++ b/src/responder/nss/nsssrv_cmd.c @@ -1123,7 +1123,8 @@ static int nss_cmd_getbynam(enum sss_cli_command cmd, struct cli_ctx *cctx) } break; default: - DEBUG(SSSDBG_CRIT_FAILURE, ("Invalid command [%d].\n", dctx->cmdctx)); + DEBUG(SSSDBG_CRIT_FAILURE, ("Invalid command [%d].\n", + dctx->cmdctx->cmd)); ret = EINVAL; } @@ -1202,7 +1203,8 @@ static void nss_cmd_getbynam_done(struct tevent_req *req) } break; default: - DEBUG(SSSDBG_CRIT_FAILURE, ("Invalid command [%d].\n", dctx->cmdctx)); + DEBUG(SSSDBG_CRIT_FAILURE, ("Invalid command [%d].\n", + dctx->cmdctx->cmd)); ret = EINVAL; } @@ -1407,7 +1409,8 @@ static int nss_cmd_getbyid(enum sss_cli_command cmd, struct cli_ctx *cctx) } break; default: - DEBUG(SSSDBG_CRIT_FAILURE, ("Invalid command [%d].\n", dctx->cmdctx)); + DEBUG(SSSDBG_CRIT_FAILURE, ("Invalid command [%d].\n", + dctx->cmdctx->cmd)); ret = EINVAL; goto done; } @@ -1452,7 +1455,8 @@ static int nss_cmd_getbyid(enum sss_cli_command cmd, struct cli_ctx *cctx) } break; default: - DEBUG(SSSDBG_CRIT_FAILURE, ("Invalid command [%d].\n", dctx->cmdctx)); + DEBUG(SSSDBG_CRIT_FAILURE, ("Invalid command [%d].\n", + dctx->cmdctx->cmd)); ret = EINVAL; } @@ -1513,7 +1517,8 @@ static void nss_cmd_getbyid_done(struct tevent_req *req) } break; default: - DEBUG(SSSDBG_CRIT_FAILURE, ("Invalid command [%d].\n", dctx->cmdctx)); + DEBUG(SSSDBG_CRIT_FAILURE, ("Invalid command [%d].\n", + dctx->cmdctx->cmd)); ret = EINVAL; } diff --git a/src/responder/nss/nsssrv_services.c b/src/responder/nss/nsssrv_services.c index 99fc67e7f..42a1deeda 100644 --- a/src/responder/nss/nsssrv_services.c +++ b/src/responder/nss/nsssrv_services.c @@ -658,7 +658,7 @@ fill_service(struct sss_packet *packet, port = (uint16_t) ldb_msg_find_attr_as_uint(msg, SYSDB_SVC_PORT, 0); if (!port) { DEBUG(SSSDBG_CRIT_FAILURE, - ("No port for service [%s]. Skipping\n")); + ("No port for service [%s]. Skipping\n", tmpstr)); } -- cgit