From d64940d823b7d860ef65e000f084fd3f62b51d81 Mon Sep 17 00:00:00 2001
From: Sumit Bose <sbose@redhat.com>
Date: Fri, 5 Nov 2010 12:20:21 +0100
Subject: Review comments for namingContexts patches

---
 src/providers/ldap/sdap.c       | 10 +++++-----
 src/providers/ldap/sdap_async.c | 18 +++++++++---------
 2 files changed, 14 insertions(+), 14 deletions(-)

(limited to 'src/providers')

diff --git a/src/providers/ldap/sdap.c b/src/providers/ldap/sdap.c
index cf4e9edc1..95b63d17c 100644
--- a/src/providers/ldap/sdap.c
+++ b/src/providers/ldap/sdap.c
@@ -474,11 +474,11 @@ errno_t sdap_set_config_options_with_rootdse(struct sysdb_attrs *rootdse,
                                         SDAP_GROUP_SEARCH_BASE,
                                         SDAP_NETGROUP_SEARCH_BASE,
                                         -1 };
-    int o;
+    size_t c;
 
 
-    for (o = 0; search_base_options[o] != -1; o++) {
-        if (dp_opt_get_string(opts->basic, search_base_options[o]) == NULL) {
+    for (c = 0; search_base_options[c] != -1; c++) {
+        if (dp_opt_get_string(opts->basic, search_base_options[c]) == NULL) {
             if (naming_context == NULL) {
                 naming_context = get_naming_context(opts->basic, rootdse);
                 if (naming_context == NULL) {
@@ -489,9 +489,9 @@ errno_t sdap_set_config_options_with_rootdse(struct sysdb_attrs *rootdse,
             }
 
             DEBUG(3, ("Setting option [%s] to [%s].\n",
-                      opts->basic[search_base_options[o]].opt_name,
+                      opts->basic[search_base_options[c]].opt_name,
                       naming_context));
-            ret = dp_opt_set_string(opts->basic, search_base_options[o],
+            ret = dp_opt_set_string(opts->basic, search_base_options[c],
                                     naming_context);
             if (ret != EOK) {
                 DEBUG(1, ("dp_opt_set_string failed.\n"));
diff --git a/src/providers/ldap/sdap_async.c b/src/providers/ldap/sdap_async.c
index 01cd96701..6808ceaa9 100644
--- a/src/providers/ldap/sdap_async.c
+++ b/src/providers/ldap/sdap_async.c
@@ -646,16 +646,16 @@ struct tevent_req *sdap_get_rootdse_send(TALLOC_CTX *memctx,
     struct tevent_req *req, *subreq;
     struct sdap_get_rootdse_state *state;
     const char *attrs[] = {
-	    "*",
-	    "altServer",
-	    SDAP_ROOTDSE_ATTR_NAMING_CONTEXTS,
-	    "supportedControl",
-	    "supportedExtension",
-	    "supportedFeatures",
-	    "supportedLDAPVersion",
-	    "supportedSASLMechanisms",
+            "*",
+            "altServer",
+            SDAP_ROOTDSE_ATTR_NAMING_CONTEXTS,
+            "supportedControl",
+            "supportedExtension",
+            "supportedFeatures",
+            "supportedLDAPVersion",
+            "supportedSASLMechanisms",
             SDAP_ROOTDSE_ATTR_DEFAULT_NAMING_CONTEXT,
-	    NULL
+            NULL
     };
 
     DEBUG(9, ("Getting rootdse\n"));
-- 
cgit