From 361e86478ff1cc7ac08981b721f508363291028c Mon Sep 17 00:00:00 2001 From: Stephen Gallagher Date: Wed, 9 Jun 2010 10:40:49 -0400 Subject: Check return code of hash_delete in proxy_child_destructor We can't do much about an error here, but we should be reporting it. https://fedorahosted.org/sssd/ticket/534 --- src/providers/proxy/proxy.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'src/providers/proxy/proxy.c') diff --git a/src/providers/proxy/proxy.c b/src/providers/proxy/proxy.c index f6e7d7bba..f2131425f 100644 --- a/src/providers/proxy/proxy.c +++ b/src/providers/proxy/proxy.c @@ -190,11 +190,17 @@ static int proxy_child_destructor(TALLOC_CTX *ctx) struct proxy_child_ctx *child_ctx = talloc_get_type(ctx, struct proxy_child_ctx); hash_key_t key; + int hret; DEBUG(8, ("Removing proxy child id [%d]\n", child_ctx->id)); key.type = HASH_KEY_ULONG; key.ul = child_ctx->id; - hash_delete(child_ctx->auth_ctx->request_table, &key); + hret = hash_delete(child_ctx->auth_ctx->request_table, &key); + if (!(hret == HASH_SUCCESS || + hret == HASH_ERROR_KEY_NOT_FOUND)) { + DEBUG(1, ("Hash error [%d][%s]\n", hret, hash_error_string(hret))); + /* Nothing we can do about this, so just continue */ + } return 0; } -- cgit