From c0d9451e86d246496e456a0925730c60c946e1d9 Mon Sep 17 00:00:00 2001
From: Stephen Gallagher <sgallagh@redhat.com>
Date: Thu, 16 Dec 2010 14:48:14 -0500
Subject: Fix unsafe return condition in ipa_access_handler

https://fedorahosted.org/sssd/ticket/718
---
 src/providers/ipa/ipa_access.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

(limited to 'src/providers/ipa')

diff --git a/src/providers/ipa/ipa_access.c b/src/providers/ipa/ipa_access.c
index 130008d2f..45f96c9b2 100644
--- a/src/providers/ipa/ipa_access.c
+++ b/src/providers/ipa/ipa_access.c
@@ -1701,7 +1701,12 @@ void ipa_access_handler(struct be_req *be_req)
     return;
 
 fail:
-    ipa_access_reply(hbac_ctx, pam_status);
+    if (hbac_ctx) {
+        /* Return an proper error */
+        ipa_access_reply(hbac_ctx, pam_status);
+    } else {
+        be_req->fn(be_req, DP_ERR_FATAL, pam_status, NULL);
+    }
 }
 
 static int hbac_retry(struct hbac_ctx *hbac_ctx)
-- 
cgit