From 60f11e2fa1f63cd40ebace525ad823b0360fac94 Mon Sep 17 00:00:00 2001 From: Sumit Bose Date: Wed, 21 Jan 2015 16:33:59 +0100 Subject: IPA: process_members() add ghosts only once Since ghost entries might not be properly removed on the IPA server (https://fedorahosted.org/sssd/ticket/2567) chances are that during extdom group lookups a single user is returned multiple time. This patch removes the duplicates before trying to write the data to the cache. Related to https://fedorahosted.org/sssd/ticket/2159 Reviewed-by: Jakub Hrozek --- src/providers/ipa/ipa_s2n_exop.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'src/providers/ipa/ipa_s2n_exop.c') diff --git a/src/providers/ipa/ipa_s2n_exop.c b/src/providers/ipa/ipa_s2n_exop.c index 997d0dce8..6f8d5687d 100644 --- a/src/providers/ipa/ipa_s2n_exop.c +++ b/src/providers/ipa/ipa_s2n_exop.c @@ -1299,8 +1299,10 @@ static errno_t process_members(struct sss_domain_info *domain, DEBUG(SSSDBG_TRACE_ALL, "Adding ghost member [%s]\n", members[c]); - ret = sysdb_attrs_add_string(group_attrs, SYSDB_GHOST, - members[c]); + /* There were cases where the server returned the same user + * multiple times */ + ret = sysdb_attrs_add_string_safe(group_attrs, SYSDB_GHOST, + members[c]); if (ret != EOK) { DEBUG(SSSDBG_OP_FAILURE, "sysdb_attrs_add_string failed.\n"); -- cgit