From 1b72f6377e997bbadabad9e5e43998dddfe38156 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Fri, 25 Jul 2014 17:39:54 +0200 Subject: AD: Increment som_index when advancing to the next GPO When the GPO processing tried to advance to the next GPO on encountering an error, the som_index was not incremented, causing an infinite loop. Reviewed-by: Yassir Elley --- src/providers/ad/ad_gpo.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src/providers/ad/ad_gpo.c') diff --git a/src/providers/ad/ad_gpo.c b/src/providers/ad/ad_gpo.c index 7c05afa39..68a612e76 100644 --- a/src/providers/ad/ad_gpo.c +++ b/src/providers/ad/ad_gpo.c @@ -2000,6 +2000,7 @@ ad_gpo_get_som_attrs_done(struct tevent_req *subreq) } if ((num_results < 1) || (results == NULL)) { DEBUG(SSSDBG_OP_FAILURE, "no attrs found for SOM; try next SOM.\n"); + state->som_index++; ret = ad_gpo_get_som_attrs_step(req); goto done; } else if (num_results > 1) { @@ -2020,6 +2021,7 @@ ad_gpo_get_som_attrs_done(struct tevent_req *subreq) if ((ret == ENOENT) || (el->num_values == 0)) { DEBUG(SSSDBG_OP_FAILURE, "no attrs found for SOM; try next SOM\n"); + state->som_index++; ret = ad_gpo_get_som_attrs_step(req); goto done; } -- cgit