From 36c50faf2674a3ebd8a6458f3c53fb72a68d1f28 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Mon, 29 Apr 2013 14:37:27 +0200 Subject: Only try to relink ghost users if we're not enumerating https://fedorahosted.org/sssd/ticket/1893 When SSSD is not enumerating (which is the default), we are trying to link any "ghost" entries with a newly created user entry. However, when enumeration is on, this means a spurious search on adding any user. --- src/db/sysdb_ops.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) (limited to 'src/db') diff --git a/src/db/sysdb_ops.c b/src/db/sysdb_ops.c index 1f27af8db..45a7265c9 100644 --- a/src/db/sysdb_ops.c +++ b/src/db/sysdb_ops.c @@ -1199,10 +1199,15 @@ int sysdb_add_user(struct sysdb_ctx *sysdb, ret = sysdb_set_user_attr(sysdb, domain, name, attrs, SYSDB_MOD_REP); if (ret) goto done; - /* remove all ghost users */ - ret = sysdb_remove_ghostattr_from_groups(sysdb, domain, - orig_dn, attrs, name); - if (ret) goto done; + if (domain->enumerate == false) { + /* If we're not enumerating, previous getgr{nam,gid} calls might + * have stored ghost users into the cache, so we need to link them + * with the newly-created user entry + */ + ret = sysdb_remove_ghostattr_from_groups(sysdb, domain, + orig_dn, attrs, name); + if (ret) goto done; + } ret = EOK; -- cgit