From cff89439b21f8573c6896b09cb1a8d5f9de3144c Mon Sep 17 00:00:00 2001 From: Michal Zidek Date: Thu, 23 Oct 2014 10:55:08 +0200 Subject: MONITOR: Fix warning may be used uninitialized MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This warning is caused be change 579e5d4b7a3ca161ea7518b2996905fa22c15995 "MONITOR: Allow confdb to be accessed by nonroot user" src/monitor/monitor.c: In function ‘main’: src/monitor/monitor.c:2953:24: error: ‘monitor’ may be used uninitialized in this function [-Werror=maybe-uninitialized] monitor->is_daemon = !opt_interactive; ^ cc1: all warnings being treated as errors Reviewed-by: Jakub Hrozek Reviewed-by: Lukáš Slebodník --- src/monitor/monitor.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/monitor/monitor.c b/src/monitor/monitor.c index 0dea32721..b55757d95 100644 --- a/src/monitor/monitor.c +++ b/src/monitor/monitor.c @@ -1723,7 +1723,9 @@ static errno_t load_configuration(TALLOC_CTX *mem_ctx, * when SSSD runs as nonroot */ ret = chown(cdb_file, ctx->uid, ctx->gid); if (ret != 0) { - ret = errno; + /* Init ret to suppress gcc warning with high -O level */ + ret = EINVAL; + if (errno) ret = errno; DEBUG(SSSDBG_FATAL_FAILURE, "chown failed for [%s]: [%d][%s].\n", cdb_file, ret, sss_strerror(ret)); -- cgit