From b6d5f2a91fbce15c7ef4d382fa6b52407adb26dd Mon Sep 17 00:00:00 2001 From: Pavel Březina Date: Tue, 6 Nov 2012 12:24:15 +0100 Subject: sss_dp_get_domains_send(): handle subreq error correctly If force is true, ret may stay uninitialized and if ret == 0 after the subrequest is send, we will go to immediate label. Data provider request is sent, but the answer is never processed. This prohibited subdomain from working correctly. --- src/responder/common/responder_get_domains.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/responder/common/responder_get_domains.c b/src/responder/common/responder_get_domains.c index f4bcbf14c..468dd761b 100644 --- a/src/responder/common/responder_get_domains.c +++ b/src/responder/common/responder_get_domains.c @@ -203,7 +203,8 @@ struct tevent_req *sss_dp_get_domains_send(TALLOC_CTX *mem_ctx, subreq = get_subdomains_send(req, rctx, state->dom, state->force, state->hint); - if (ret != EAGAIN) { + if (subreq == NULL) { + ret = ENOMEM; goto immediately; } tevent_req_set_callback(subreq, sss_dp_get_domains_process, req); -- cgit