From a471b7def3bed010ab60c39cc5201ea0089409a2 Mon Sep 17 00:00:00 2001 From: Stephen Gallagher Date: Wed, 29 Feb 2012 10:37:41 -0500 Subject: Handle cases where UID is -1 Also removes an unnecessary range check (since it's already handled by strtoint32() https://fedorahosted.org/sssd/ticket/1216 (cherry picked from commit f5df473c0234bf4b701a29f4feb61ad52f70b236) --- src/util/find_uid.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/util/find_uid.c b/src/util/find_uid.c index e4d4ca8be..22cf47c02 100644 --- a/src/util/find_uid.c +++ b/src/util/find_uid.c @@ -132,7 +132,7 @@ static errno_t get_uid_from_pid(const pid_t pid, uid_t *uid) } else { *e = '\0'; } - num = strtouint32(p, &endptr, 10); + num = (uint32_t) strtoint32(p, &endptr, 10); error = errno; if (error != 0) { DEBUG(1, ("strtol failed [%s].\n", strerror(error))); @@ -143,11 +143,6 @@ static errno_t get_uid_from_pid(const pid_t pid, uid_t *uid) return EINVAL; } - if (num >= UINT32_MAX) { - DEBUG(1, ("uid out of range.\n")); - return ERANGE; - } - } else { DEBUG(1, ("format error\n")); return EINVAL; -- cgit