From 8e1d9a326a6cf88405344077a309cbe3898653c9 Mon Sep 17 00:00:00 2001 From: Jan Zeleny Date: Fri, 15 Jun 2012 14:26:20 -0400 Subject: Fix possible segfault in sdap_save_group() --- src/providers/ldap/sdap_async_groups.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/providers/ldap/sdap_async_groups.c b/src/providers/ldap/sdap_async_groups.c index 3c3a954e4..858c8c90c 100644 --- a/src/providers/ldap/sdap_async_groups.c +++ b/src/providers/ldap/sdap_async_groups.c @@ -344,7 +344,8 @@ static int sdap_save_group(TALLOC_CTX *memctx, } } - ret = sysdb_attrs_get_el(attrs, opts->group_map[SDAP_AT_GROUP_MEMBER].sys_name, &el1); + ret = sysdb_attrs_get_el(attrs, opts->group_map[SDAP_AT_GROUP_MEMBER].sys_name, + &el1); if (ret != EOK) { goto fail; } @@ -356,13 +357,21 @@ static int sdap_save_group(TALLOC_CTX *memctx, } el->values = el1->values; el->num_values = el1->num_values; - } ret = sysdb_attrs_get_el(attrs, SYSDB_GHOST, &gh); if (ret != EOK) { goto fail; } + if (gh->num_values == 0) { + ret = sysdb_attrs_get_el(attrs, + opts->group_map[SDAP_AT_GROUP_MEMBER].sys_name, + &el1); + if (ret != EOK) { + goto fail; + } + } + ret = sysdb_attrs_get_el(group_attrs, SYSDB_GHOST, &el); if (ret != EOK) { goto fail; -- cgit