From 84a4e4533b3af5b170e19827f428b7df76b69d71 Mon Sep 17 00:00:00 2001 From: Stephen Gallagher Date: Mon, 9 Jul 2012 12:12:50 -0400 Subject: Check for errors from krb5_unparse_name Coverity #12781 --- src/util/sss_krb5.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/util/sss_krb5.c b/src/util/sss_krb5.c index 8180d73d5..24229f8b3 100644 --- a/src/util/sss_krb5.c +++ b/src/util/sss_krb5.c @@ -327,7 +327,14 @@ int sss_krb5_verify_keytab_ex(const char *principal, const char *keytab_name, found = false; while((krb5_kt_next_entry(context, keytab, &entry, &cursor)) == 0){ - krb5_unparse_name(context, entry.principal, &kt_principal); + krberr = krb5_unparse_name(context, entry.principal, &kt_principal); + if (krberr) { + DEBUG(SSSDBG_FATAL_FAILURE, + ("Could not parse keytab entry\n")); + sss_log(SSS_LOG_ERR, "Could not parse keytab entry\n"); + return EIO; + } + if (strcmp(principal, kt_principal) == 0) { found = true; } -- cgit