From 80c092f94a7ac24ea00e560201e37ae27cfbf665 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Sat, 24 May 2014 19:36:39 +0200 Subject: LDAP: Don't use macro _XOPEN_SOURCE for extra features We defined macro _XOPEN_SOURCE before time.h, because we need function strptime The problem is with undef after including header time.h The macro _XOPEN_SOURCE can be defined on some platforms and undef can cause problems. We detect all necessary feature macros in configure script using AC_USE_SYSTEM_EXTENSIONS or AC_GNU_SOURCE. It is better to include header file config.h instead of defining macro _XOPEN_SOURCE Reviewed-by: Jakub Hrozek --- src/providers/ldap/ldap_auth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/providers/ldap/ldap_auth.c b/src/providers/ldap/ldap_auth.c index 2a7d06ca2..40f297c16 100644 --- a/src/providers/ldap/ldap_auth.c +++ b/src/providers/ldap/ldap_auth.c @@ -30,9 +30,9 @@ #define LDAP_TAG_EXOP_MODIFY_PASSWD_NEW ((ber_tag_t) 0x82U) #endif -#define _XOPEN_SOURCE 500 /* for strptime() */ +#include "config.h" + #include -#undef _XOPEN_SOURCE #include #include #include -- cgit