From 5dbdcc2c7210a0e3eb60ad1e85ba33f27d7faeda Mon Sep 17 00:00:00 2001 From: Pavel Reichl Date: Thu, 3 Sep 2015 04:46:50 -0400 Subject: GPO: fix memory leak MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Resolves: https://fedorahosted.org/sssd/ticket/2777 Reviewed-by: Michal Židek --- src/providers/ad/ad_gpo.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/providers/ad/ad_gpo.c b/src/providers/ad/ad_gpo.c index ffd8ac5dd..12632e56e 100644 --- a/src/providers/ad/ad_gpo.c +++ b/src/providers/ad/ad_gpo.c @@ -560,14 +560,14 @@ ad_gpo_get_sids(TALLOC_CTX *mem_ctx, DEBUG(SSSDBG_OP_FAILURE, "sysdb_initgroups failed: [%d](%s)\n", ret, sss_strerror(ret)); - return ret; + goto done; } if (res->count == 0) { ret = ENOENT; DEBUG(SSSDBG_OP_FAILURE, "sysdb_initgroups returned empty result\n"); - return ret; + goto done; } user_sid = ldb_msg_find_attr_as_string(res->msgs[0], SYSDB_SID_STR, NULL); @@ -602,7 +602,7 @@ ad_gpo_get_sids(TALLOC_CTX *mem_ctx, *_group_size = num_group_sids + 1; *_group_sids = talloc_steal(mem_ctx, group_sids); *_user_sid = talloc_steal(mem_ctx, user_sid); - return EOK; + ret = EOK; done: talloc_free(tmp_ctx); -- cgit