From 0fc5c8d9424a2373ef0aa7ebdec337b01a5f55c9 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Thu, 5 Apr 2012 14:03:46 -0400 Subject: netlink integration: ensure that interface name is NULL-terminated In the unlikely case that the interface name was IFNAMSIZ bytes long or longer, strncpy wouldn't NULL-terminate the buffer. Copy one byte less to ensure the buffer is NULL-terminated. --- src/monitor/monitor_netlink.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/monitor/monitor_netlink.c b/src/monitor/monitor_netlink.c index 8455f6889..2fe380ac9 100644 --- a/src/monitor/monitor_netlink.c +++ b/src/monitor/monitor_netlink.c @@ -117,7 +117,8 @@ static bool has_wireless_extension(const char *ifname) return false; } - strncpy(iwr.ifr_ifrn.ifrn_name, ifname, IFNAMSIZ); + strncpy(iwr.ifr_ifrn.ifrn_name, ifname, IFNAMSIZ-1); + iwr.ifr_ifrn.ifrn_name[IFNAMSIZ-1] = '\0'; /* Does the interface support a wireless extension? */ ret = ioctl(s, SIOCGIWNAME, &iwr); close(s); -- cgit