summaryrefslogtreecommitdiffstats
path: root/common
Commit message (Collapse)AuthorAgeFilesLines
* ELAPI Compatibility code for getifaddr()Dmitri Pal2009-10-1610-20/+357
| | | | | | | | | | Addreses ticket #94 Actually works pretty well. To try use --enable-compat when build ELAPI. It will use compatibility code instead of getifaddr(). The trick in the elapi_ioctl.h with memory allocation is taken from Stevens book.
* ELAPI Fixed the host name resolutionDmitri Pal2009-10-052-13/+111
| | | | | | | | The issue was that the host IP was recorded twice, once as a main address and another as IP alias. It seemed that the IP was returned as name but the issue turned out to be different. See https://fedorahosted.org/sssd/ticket/207.
* ELAPI Rename variables and functions not to use word templateDmitri Pal2009-10-057-113/+113
| | | | | | Addressing Ticket #191. Renamed all varibles from 'template' to 'tpl'. Used 'tplt' in function names instead of 'templete'.
* INI Add config_from_fd() to ini_configStephen Gallagher2009-10-053-22/+239
| | | | | | | Patch adds ability to read configuration using already open file descriptor. Started by Steve G and refined a bit by me.
* ELAPI Fixing warnings in the exampleDmitri Pal2009-10-051-2/+9
|
* ELAPI Resolving message attributeDmitri Pal2009-10-058-57/+536
| | | | | | | | | | | | This patch continues work started with the previous patch. It resolves message attribute. Message attribute is a special attribute in the event that may contain references to other attributes in the event. When message is resolved the references are replaced with actual values of the referenced attributes.
* ELAPI Event resolverDmitri Pal2009-10-0514-95/+828
| | | | | | | | | | | | | | | | | Started working on the async processing and realised that I need to have a good copy of the event with all the fields resolved so this patch has some foundation for the async functions (module elapi_async.c) but they are mostly stubbed out. The actual code will be added down the road. Instead the patch focuses on the code introduced in elapi_resolve.c module and the use of the functions from it. It also adds the implementation of the high level calls that initialize ELAPI with the external callbacks to be used during async processing (elapi_log.c).
* COLLECTION Enhancing hashing and iteration functionsDmitri Pal2009-10-054-8/+76
|
* COLLECTION Making iterations pinnableDmitri Pal2009-10-054-7/+220
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a feature that helps ELAPI. It makes lookup of the fields that need to be resolved for every event a bit faster. The idea is to be able to put a 'pin' into a specific place while iterating the collection and make this place a new "wrap around" place for the collection. This means that next time you iterate this collection you will start iterating from the next item and the item you got before pin will be last in your iteration cycle. Here is the example: Assume you have two collections that you need to compare and perform some action on collection 1 based on the presense of the item in collection 2. Collection1 = A, B, C, D, E. F Collection2 = A, C, F The usual approach is to try A from collection 1 against A, B, C from collection 2. "A" will be found right away. But to find "F" it has to be compared to "A" and "C" first. The fact that the collections are to some extent ordered can in some cases help to reduce the number of comparisons. If we found "C" in the list we can put a "pin" into the collection there causing the iterator to warp at this "pin" point. Since "D" and "E" are not in the second collection we will have to make same amount of comparisons in traditional or "pinned" case to not find them. To find "F" in pinned case there will be just one comparison. Traditional case = 1 + 3 + 2 + 3 + 3 + 3 = 15 Pinned case = 1 + 3 + 1 + 3 + 3 + 1 = 12 It is a 20% comparison reduction.
* COLLECTION Realigning collection codeDmitri Pal2009-10-054-330/+372
| | | | | | | | | | Created a new module to hold functions related to iterator and iterating collections. Planning to add new functions but the main collection module is already too big. So this patch just moves code around and fixes the build making foundation for the next patch.
* COLLECTION Adding item comparison and sortingDmitri Pal2009-10-057-5/+697
| | | | | | | | | | | Needed item comparison functions and realized that the easiest way to test them would be using sorting. Since there already been a ticket #73 to do that I added function to sort collection based on different properties of the item. COLLECTION Fixing issues with comparisons COLLECTION Adding do-while to macro
* ELAPI: Ticket 161: Initialize structures with calloc instead of enumerating ↵Jakub Hrozek2009-09-215-36/+6
| | | | members
* ELAPI: fix varargs call, update unit testsJakub Hrozek2009-09-213-8/+58
|
* ELAPI: Fix dispatcher structure initializationJakub Hrozek2009-09-161-10/+1
|
* Include m4 directories in tarballStephen Gallagher2009-09-157-5/+20
| | | | Necessary for RPM builds on RHEL5
* INI Error handling and interface cleanupDmitri Pal2009-09-152-30/+86
| | | | | | | | Inspired by issue #173 I reviewed the other function of the interface and found a lot of problems with its error handling. Also made INI use collection public interfaces.
* Add 'make tests' targetStephen Gallagher2009-09-118-0/+21
|
* ELAPI Better separation from collection internals.Dmitri Pal2009-09-111-20/+24
| | | | | | This patch eliminates the need to include collection's private header and uses only public interface.
* COLLECTION Functions to deal with hashDmitri Pal2009-09-113-17/+71
| | | | | | | | | | | | | | | The hashing logic was internal to the collection item. But if someone wants to effectively deal with the items and compare the property to a string he should compare hashes first. But it was not possible without the provided functions. As a result some of the ELAPI modules had to take advantage of knowledge of the item structure. This is bad. So this patch lays foundation for refactoring of the ELAPI code that was using internals of the item directly (file_util.c mostly). Also patch adds a unit test that was required for testing new functionality and for ticket #83
* COLLECTION Improvements to copy functionsDmitri Pal2009-09-104-51/+191
| | | | | | | | | | | | | | | | | | | | This patch adds better options for copying collections in flat mode. It allows caller of the interface to control prefixing of the fields when one collection is appended to another. It also avoids creating prefixes when the collection is simply copied in flat mode. Also for ELAPI I realized that the most efficient way to deal with the "resolved" event (event where all templeted values are actually replaced with the real values) is to add a callback capability to a copy collection function so that the callback can be used to modify the data (resolve it) while the copy operation is in progress. This approach eliminates the need for separate set of lookups after the event is already copied.
* COLLECTION Copy collection flat with concatenated namesDmitri Pal2009-09-095-239/+365
| | | | | | | | | | | | | | | | | | | | | This patch addresses several issues: a) Adds capability to add or copy the collections in flattened mode but construct names of attributes in dotted notation. For example when you append collection "sub" with items "foo" and "bar" previously you could add them as "foo" and "bar" not you can flatten them and the names will be "sub.foo" and "sub.bar" this allows better processing of the attributes in the elapi message. b) Removes old implemntation of the copy collection function. c) Removes the col_set_timestamp, this functionality has been moved to ELAPI long ago. d) Updates collection unit test. e) Updates elapi to use new functionality f) Updates elapi unit test Have run under valgrind with no problems.
* ELAPI Laying foundation for the async processingDmitri Pal2009-09-086-90/+175
| | | | | | | A relatively small patch aligning headers and a small portion of code for upcoming implementation of the async event processing. Cleanup of the test config file.
* ELAPI Adding file provider and CSV formatDmitri Pal2009-09-0820-139/+2250
| | | | | | | | | | | | | | | | | | | | | This patch creates the infrastructure for logging of the event from the top of the interface to the bottom. It is a start. A lot of functionality is left aside. The attempt of this patch is pass event from caller of the ELAPI interface via targets to sinks then to providers and do serialization creating entity that is ready to be written to a file. It also implements more specific provider related configuration parameters. Also it addresses couple suggestions that were brought up against previous patch. ELAPI Correcting issues This patch addresses the issues found during the review of the previous patches and addresses ticket #166.
* ELAPI sinks and providersDmitri Pal2009-09-089-143/+1016
| | | | | | | | | This patch drills down to the next level of ELAPI functionality. I adds the creation and loading of the sinks. It also implements a skeleton for the first low level provider which will be capable of writing to a file. The configuration ini file is extended to define new configuration parameters and their meanings.
* configure cleanupsSumit Bose2009-09-035-5/+7
| | | | | - replaced mailing list address - let sssd base components read version from VERSION
* ELAPI Shortening namesDmitri Pal2009-08-214-154/+152
| | | | | | | Per ticket #118 shortened naimes of some functions and structs I added into ELAPI during last big functional patch . There is no plan to do a global shortening of all names but miving forward I will try to make them shorter than I used to.
* COMMON Fixes to return values, errno, leaksDmitri Pal2009-08-207-62/+69
| | | | | | | | | | | | | | | | | | | | Started looking at the ticket #107 related to traverse functions. Realized that the return values are not consistent. That ovelapped with the work that I wanted to do for ticket #103 - errno cleanup. So I (across collection, INI and ELAPI): * Made the return codes consistent (where found) * Removed errno where it is not needed While was testing used valgrind and found a nasty problem when the value was added to collection with overwriting duplicates the count was decreased improperly. Fixing collection.c to not decrease count made valgrind happy. While I was debugging this I also spotted several build warnings in trace statements when the " exp ? v1 : v2 " was used. Fixed those. In ini_config.c there was a trace stament that used variable after it was freed. Removed trace stament.
* ELAPI: Adding concept of targetsDmitri Pal2009-08-2015-162/+899
| | | | | | | | | | | | | | | | | | | | | | | | | The targets are the destinations which caller wants to send the events to. The sinks are now on the second level under targets and constitute a so called fail over chain for a target. Such approach eliminates the need for complex routing function. The dispatcher keeps the list of targets in a collection. The element in the collection is the target context. Also gispatcher keeps the list of the sinks in a separate collection. Each target context has a list of the sinks associated with this target. But those are just pointers (at least for now) to the sinks form the list kept by dispatcher. I had to add some internal debug callbacks to be able to see that all the internals of the dispatcher are actually in order. See the conttent of config file for more comments. Also see information posted on SSSD wiki. https://fedorahosted.org/sssd/wiki/WikiPage/ELAPIInterface
* TRACE: Making sure trace is safe to output NULL stringsDmitri Pal2009-08-172-99/+6
| | | | | Patch adds checks for NULL to the trace macros. It also eliminates the unused trace.h in the collection directory.
* ELAPI Next round of functionality - logging part of the interfaceDmitri Pal2009-08-1214-263/+1522
| | | | | | | | | | | a) Added the main logging interface which allows creating dispatcher and logging messages or events. Can't actully log anything yet since the sinks are stubbed out. b) Made default template be a part of the default dispatcher. c) Updated UNIT test. d) Some of the calls are stubbed out but they are there to indicate where next round of work will be.
* INI Simple fix to properly process multi value config parameters.Dmitri Pal2009-08-122-2/+3
| | | | Also fixed a typo in the header file.
* Fix typo in elapi's Makefile.am that breaks 'make dist'Stephen Gallagher2009-07-201-1/+1
|
* COLLECTION & INI CleanupDmitri Pal2009-07-205-86/+113
| | | | | | | | | | | | | | | | I started to cleanup the unit tests from the type cust around NULL and found several problems that I had to address: 1) The choice of the "." as a search separator turned out to be a poor choice. The problem was that the file name has "." and INI was relaying on files to be used as property names. I corrected that part in the INI but after discussion with Simo we decided to switch from "." to "!" as special symbol anyways. 2) Found that the property rename was not reinitializing the hash. Corrected. Added ticket to add unit tests around it (#83).
* COLLECTION Improving searchesDmitri Pal2009-07-162-9/+181
| | | | | | Addressing ticket #71. The searches were not taking advantage of the hashes, now they are.
* Run ini_config unit test with "make check"Stephen Gallagher2009-07-162-2/+19
| | | | | Also adds support for running ini_config_ut under a parallel build directory.
* Run libcollection unit tests with 'make check'Stephen Gallagher2009-07-161-1/+3
|
* COLLECTION Add remove item functionsDmitri Pal2009-07-164-31/+146
| | | | | | | | | | | | | The remove functions extract and remove items, they act differently from the way the delete_property function works. The new functions allow deletion with the disposition while the delete_property only deletes specified property. The delete_property function is left as is since there are some use cases when it is more efficient to use it rather than new remove_item_xxx ones.
* INI Refactoring code a bitDmitri Pal2009-07-162-42/+16
| | | | | | | The inefficient function from ini_config.c is replaced with the function provided now by the collection interface. Also the unit test is updated to run from the local directory.
* ELAPI First part of the interfaceDmitri Pal2009-07-1512-4/+1655
| | | | | | | | | | | This is just a part of the interface, a beginning. Most likely some of the functions will be altered but it is a starting point. For example in future there will be a way to override some of the parts of the default template using the application configuration file. Removed obfuscation of the data types based on discussion with Simo.
* COLLECTION Fixed: iterator_up and insert_into_currentDmitri Pal2009-07-153-17/+83
| | | | | | | | | | | During a review of the previous patch the two issues were found: a) The col_iterator_up function was not implemented properly so it got reworked. New implementation changes the way error condition is handled. Comments were updated accordingly. b) There was a mising check for validity of the argument in the col_insert_into_current function. Check was added. c) Unit test modified to reflect the change in functionality.
* COLLECTION Adding flat traversal & copyDmitri Pal2009-07-155-99/+598
| | | | | | | | | | | | The collection is hearachical. The flattening of the collection was not implemented before both for traversal and copying. This patch introduces functionality to traverse or iterate through collection as flat set and also copy collection into another flattening it and automatically resolving conflicts. Also imptoved tracability and fixed memory leak in unbind iterator code.
* add path_utils filesystem path manipulation utility functionsJohn Dennis2009-07-158-2/+840
| | | | | | | | | | | | | | | | | | remove trace macro, not needed modifications to satisfy Stephen's checkin review correct spelling of PATH_UTILS_ERROR_NOT_FULLY_NORMALIZED add checks for truncation, return error add checks for getcwd errors modify (dst >= dst_end) test to be (dst > dst_end) remove all use of tabs remove all trailing whitespace add missing truncation check after strncpy() Fix path_utils.pc Also correct a minor typo.
* Build all SSSD components with warnings enabledStephen Gallagher2009-07-136-3/+33
| | | | | | Previously, only the SSSD server components were being built with compile-time warnings enabled. This patch will ensure that all components in common and sss_client are also built the same way.
* COLLECTION Removing static placeholder structure.Dmitri Pal2009-07-062-5/+20
| | | | | | There was a static global structure used in iteration and in traversing the collection. It has been removed and replaced with a better solution.
* Clean up warnings in common/Simo Sorce2009-07-0316-108/+110
| | | | Fix consts and function declarations
* Adding wrappers to free data in INI API.Dmitri Pal2009-07-023-58/+91
| | | | See ticket #37 in sssd track.
* Changing function names for collection API.Dmitri Pal2009-07-0214-2698/+2778
| | | | | | | Patch prepends prefix "col_" to all functions related to collection. This caused some formatiing issues so the alignement was addressed too.
* New deletion unit test.Dmitri Pal2009-07-022-2/+36
| | | | | | Adds a unit test for deletion and re-adding of the elements to collection. Small syntactical fix in "stack".
* Queue and stack APIs using collection.Dmitri Pal2009-07-028-2/+1081
| | | | | | | Patch adds two interfaces for stack and queue using collection as underlaying implementation. It also fixes a bug in the insterion code - the unsigned properties were created as long.
* FORMATTING - minor cleanup of the unit test.Dmitri Pal2009-07-021-254/+283
| | | | | | | | | | | | | This patch adds formatting changes to better follow the style guidelines in the collection unit test. No logical changes to the code. I was planning to do it for a while per Simo's comment when he accepted the core of the collection code but indicated that the unit test should be cleaned later. Later has come.
generated by cgit (git 2.34.1) at 2024-04-24 12:31:31 +0000