diff options
| author | Lukas Slebodnik <lslebodn@redhat.com> | 2013-06-25 09:44:17 +0200 |
|---|---|---|
| committer | Jakub Hrozek <jhrozek@redhat.com> | 2013-08-08 17:06:01 +0200 |
| commit | 67771f699d39135431a1adbde5eb032e7697a608 (patch) | |
| tree | e0310c437810fc7b34c59bc92028d224a3504518 /src | |
| parent | 5d762a91faf65e256bfd6b0351494a611ecf34ac (diff) | |
| download | sssd-67771f699d39135431a1adbde5eb032e7697a608.tar.gz sssd-67771f699d39135431a1adbde5eb032e7697a608.tar.xz sssd-67771f699d39135431a1adbde5eb032e7697a608.zip | |
Do not call sss_cmd_done in function check_cache.
Function sysdb_getpwnam return more results than 1 and therefore sss_cmd_done
was called. Inside of function sss_cmd_done memory was freed,
but this freed memory was used in caller functions, therefore sssd crashed.
https://fedorahosted.org/sssd/ticket/1980
Diffstat (limited to 'src')
| -rw-r--r-- | src/responder/nss/nsssrv_cmd.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/src/responder/nss/nsssrv_cmd.c b/src/responder/nss/nsssrv_cmd.c index 7df55322a..9932ef550 100644 --- a/src/responder/nss/nsssrv_cmd.c +++ b/src/responder/nss/nsssrv_cmd.c @@ -492,7 +492,6 @@ static int nss_cmd_getpw_send_reply(struct nss_dom_ctx *dctx, bool filter) static void nsssrv_dp_send_acct_req_done(struct tevent_req *req); /* FIXME: do not check res->count, but get in a msgs and check in parent */ -/* FIXME: do not sss_cmd_done, but return error and let parent do it */ errno_t check_cache(struct nss_dom_ctx *dctx, struct nss_ctx *nctx, struct ldb_result *res, @@ -516,11 +515,6 @@ errno_t check_cache(struct nss_dom_ctx *dctx, (res->count > 1)) { DEBUG(1, ("getpwXXX call returned more than one result!" " DB Corrupted?\n")); - ret = nss_cmd_send_error(cmdctx, ENOENT); - if (ret != EOK) { - NSS_CMD_FATAL_ERROR_CODE(cctx, ENOENT); - } - sss_cmd_done(cctx, cmdctx); return ENOENT; } |