summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorJakub Hrozek <jhrozek@redhat.com>2012-12-15 19:56:33 +0100
committerJakub Hrozek <jhrozek@redhat.com>2012-12-18 11:34:11 +0100
commit449fd66aa70c284dd91d51c49363ef9e941dba8d (patch)
tree5fdd1a40dd650286da32949e84976d09f26e0dfa /src
parentb1c0ad085fbfd9d2e29de15b131d2ff642b15708 (diff)
downloadsssd-449fd66aa70c284dd91d51c49363ef9e941dba8d.tar.gz
sssd-449fd66aa70c284dd91d51c49363ef9e941dba8d.tar.xz
sssd-449fd66aa70c284dd91d51c49363ef9e941dba8d.zip
Set cloexec flag for log files
https://fedorahosted.org/sssd/ticket/1708 The services kept the fd to /var/log/sssd/sssd.log open. I don't think there's any point in keeping the logfiles open after exec-ing for the child, so I set the CLOEXEC flag.
Diffstat (limited to 'src')
-rw-r--r--src/util/debug.c11
1 files changed, 11 insertions, 0 deletions
diff --git a/src/util/debug.c b/src/util/debug.c
index cb90d65ac..f107f168b 100644
--- a/src/util/debug.c
+++ b/src/util/debug.c
@@ -24,6 +24,7 @@
#include <stdio.h>
#include <stdarg.h>
#include <stdlib.h>
+#include <fcntl.h>
#include <sys/types.h>
#include <sys/stat.h>
@@ -179,6 +180,8 @@ int open_debug_file_ex(const char *filename, FILE **filep)
const char *log_file;
mode_t old_umask;
int ret;
+ int debug_fd;
+ int flags;
if (filename == NULL) {
log_file = debug_log_file;
@@ -204,6 +207,14 @@ int open_debug_file_ex(const char *filename, FILE **filep)
}
umask(old_umask);
+ debug_fd = fileno(f);
+ if (debug_fd == -1) {
+ return EIO;
+ }
+
+ flags = fcntl(debug_fd, F_GETFD, 0);
+ (void) fcntl(debug_fd, F_SETFD, flags | FD_CLOEXEC);
+
if (filep == NULL) {
debug_file = f;
} else {