summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorLukas Slebodnik <lslebodn@redhat.com>2014-03-12 18:03:26 +0100
committerJakub Hrozek <jhrozek@redhat.com>2014-06-03 16:23:16 +0200
commitfa9d2469b32deae25eaa091b36fa104a84cd6d6a (patch)
tree50a3098bcab6cdfc307443654a7ca283db5d5f6b /src
parent2d9df96c8a801ababcb136f665f3f1ebd0ac05c1 (diff)
downloadsssd-fa9d2469b32deae25eaa091b36fa104a84cd6d6a.tar.gz
sssd-fa9d2469b32deae25eaa091b36fa104a84cd6d6a.tar.xz
sssd-fa9d2469b32deae25eaa091b36fa104a84cd6d6a.zip
KRB: Prevent dereference of a null pointer
Reported by: scan-build krb5_free_principal(cc->context, ccprinc); ^~ warning: Access to field 'context' results in a dereference of a null pointer (loaded from variable 'cc') Variable 'cc' needn't be initialised if function sss_open_ccache_as_user fails. Reviewed-by: Sumit Bose <sbose@redhat.com>
Diffstat (limited to 'src')
-rw-r--r--src/providers/krb5/krb5_utils.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/src/providers/krb5/krb5_utils.c b/src/providers/krb5/krb5_utils.c
index 5fa750680..aedf6a15d 100644
--- a/src/providers/krb5/krb5_utils.c
+++ b/src/providers/krb5/krb5_utils.c
@@ -975,8 +975,10 @@ errno_t sss_krb5_check_ccache_princ(uid_t uid, gid_t gid,
ret = ERR_NOT_FOUND;
done:
- krb5_free_principal(cc->context, ccprinc);
- krb5_free_principal(cc->context, kprinc);
+ if (cc) {
+ krb5_free_principal(cc->context, ccprinc);
+ krb5_free_principal(cc->context, kprinc);
+ }
talloc_free(tmp_ctx);
return ret;
}