diff options
| author | Lukas Slebodnik <lslebodn@redhat.com> | 2014-03-12 17:38:22 +0100 |
|---|---|---|
| committer | Jakub Hrozek <jhrozek@redhat.com> | 2014-03-12 22:31:08 +0100 |
| commit | 5376ee92896f37a193dbc77451e15180cd7e6640 (patch) | |
| tree | 038fddd3a7c1fc70d7ddbe33384f5a75f8f69fcc /src | |
| parent | bd4a4ee2d81787a32787dc480a0fa8f6c5d54633 (diff) | |
| download | sssd-5376ee92896f37a193dbc77451e15180cd7e6640.tar.gz sssd-5376ee92896f37a193dbc77451e15180cd7e6640.tar.xz sssd-5376ee92896f37a193dbc77451e15180cd7e6640.zip | |
AD: Continue if sssd failes to check extra members
Reported by scan-build
for (mi = 0; group_only[mi]; mi++) {
^~~~~~~~~~
warning: Array access (from variable 'group_only') results in a null pointer
dereference
It can happend if function ad_group_extra_members fails (ret != EOK)
Reviewed-by: Simo Sorce <simo@redhat.com>
(cherry picked from commit bad65473c4c28ecbf2b6bd374a7ae2d634d57d8d)
Diffstat (limited to 'src')
| -rw-r--r-- | src/providers/ad/ad_id.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/providers/ad/ad_id.c b/src/providers/ad/ad_id.c index a35823b4b..01d18d7ae 100644 --- a/src/providers/ad/ad_id.c +++ b/src/providers/ad/ad_id.c @@ -772,6 +772,7 @@ ad_enum_cross_dom_members(struct sdap_options *opts, ret = ad_group_extra_members(tmp_ctx, msgs[i], dom, &group_only); if (ret != EOK) { DEBUG(SSSDBG_OP_FAILURE, ("Failed to check extra members\n")); + continue; } else if (group_only == NULL) { DEBUG(SSSDBG_TRACE_INTERNAL, ("No extra members\n")); continue; |