summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorLukas Slebodnik <lslebodn@redhat.com>2014-10-11 13:10:18 +0200
committerJakub Hrozek <jhrozek@redhat.com>2014-10-13 16:12:08 +0200
commitdd09bbb2578bd9f82afd7fc4d4fcc3a5659731d3 (patch)
tree3ea5ecf7a7d4f022a681cc51cd3fd441a8f5c683 /src
parentb083fec6c175989e0d32b83d8cc857a6b54d26a2 (diff)
downloadsssd-dd09bbb2578bd9f82afd7fc4d4fcc3a5659731d3.tar.gz
sssd-dd09bbb2578bd9f82afd7fc4d4fcc3a5659731d3.tar.xz
sssd-dd09bbb2578bd9f82afd7fc4d4fcc3a5659731d3.zip
GPO: Fail if we cannot retrieve gpo from cache.
The variable value could be used uninitialized. Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>
Diffstat (limited to 'src')
-rw-r--r--src/providers/ad/ad_gpo.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/src/providers/ad/ad_gpo.c b/src/providers/ad/ad_gpo.c
index d581db8fc..2d8ba82da 100644
--- a/src/providers/ad/ad_gpo.c
+++ b/src/providers/ad/ad_gpo.c
@@ -1358,6 +1358,12 @@ parse_policy_setting_value(TALLOC_CTX *mem_ctx,
char **sids_list = NULL;
ret = sysdb_gpo_get_gpo_result_setting(mem_ctx, domain, key, &value);
+ if (ret != EOK) {
+ DEBUG(SSSDBG_OP_FAILURE,
+ "Cannot retrieve settings from sysdb for key: '%s' [%d][%s].\n",
+ key, ret, sss_strerror(ret));
+ goto done;
+ }
if (value == NULL) {
DEBUG(SSSDBG_TRACE_FUNC,