diff options
| author | Lukas Slebodnik <lslebodn@redhat.com> | 2014-03-12 17:38:22 +0100 |
|---|---|---|
| committer | Jakub Hrozek <jhrozek@redhat.com> | 2014-03-12 22:28:35 +0100 |
| commit | bad65473c4c28ecbf2b6bd374a7ae2d634d57d8d (patch) | |
| tree | 558a7b5a352e4c4a59e68001c484468dd754de17 /src | |
| parent | 63bf0b7697d5a51b5338070d0e2652d49a4728ce (diff) | |
| download | sssd-bad65473c4c28ecbf2b6bd374a7ae2d634d57d8d.tar.gz sssd-bad65473c4c28ecbf2b6bd374a7ae2d634d57d8d.tar.xz sssd-bad65473c4c28ecbf2b6bd374a7ae2d634d57d8d.zip | |
AD: Continue if sssd failes to check extra members
Reported by scan-build
for (mi = 0; group_only[mi]; mi++) {
^~~~~~~~~~
warning: Array access (from variable 'group_only') results in a null pointer
dereference
It can happend if function ad_group_extra_members fails (ret != EOK)
Reviewed-by: Simo Sorce <simo@redhat.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/providers/ad/ad_id.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/providers/ad/ad_id.c b/src/providers/ad/ad_id.c index e68c8a8ff..3425b3555 100644 --- a/src/providers/ad/ad_id.c +++ b/src/providers/ad/ad_id.c @@ -753,6 +753,7 @@ ad_enum_cross_dom_members(struct sdap_options *opts, ret = ad_group_extra_members(tmp_ctx, msgs[i], dom, &group_only); if (ret != EOK) { DEBUG(SSSDBG_OP_FAILURE, "Failed to check extra members\n"); + continue; } else if (group_only == NULL) { DEBUG(SSSDBG_TRACE_INTERNAL, "No extra members\n"); continue; |