sss_client: Fix "struct sss_cli_mc_ctx" reinitialize-on-errors

When we have difficulty setting up an sss_cli_mc_ctx structure, we try
to clean things up so that we'll be ready to try again the next time
we're called.

Part of that is closing the descriptor of the file if we've opened it
and using memset() to clear the structure.

Now that sss_nss_mc_get_ctx() does its work in two phases, and each one
may end up doing the cleanup, each needs to be careful to reset the
descriptor field so that the new value provided by memset() (0) isn't
mistakenly treated as a file which should be closed by the other.

Resolves:
https://fedorahosted.org/sssd/ticket/2409

Reviewed-by: Simo Sorce <simo@redhat.com>

1 files changed, 2 insertions, 0 deletions

diff --git a/src/sss_client/nss_mc_common.c b/src/sss_client/nss_mc_common.c
index cd1ac42da..6c9b35de2 100644
--- a/src/sss_client/nss_mc_common.c
+++ b/src/sss_client/nss_mc_common.c
@@ -164,6 +164,7 @@ done:
             close(ctx->fd);
         }
         memset(ctx, 0, sizeof(struct sss_cli_mc_ctx));
+        ctx->fd = -1;
     }
     free(file);
     sss_nss_unlock();
@@ -197,6 +198,7 @@ done:
             close(ctx->fd);
         }
         memset(ctx, 0, sizeof(struct sss_cli_mc_ctx));
+        ctx->fd = -1;
     }
     return ret;
 }