summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorMichal Zidek <mzidek@redhat.com>2012-12-03 13:53:04 +0100
committerJakub Hrozek <jhrozek@redhat.com>2012-12-06 11:29:31 +0100
commita55e32d1bdb238d3ce3d89212d8da23110f20894 (patch)
tree5b0df45f6a2290609ac909267444eb753ca5996e /src
parent9cd9a6776c5afb03e094fb17c8da7ee8fe768285 (diff)
downloadsssd-a55e32d1bdb238d3ce3d89212d8da23110f20894.tar.gz
sssd-a55e32d1bdb238d3ce3d89212d8da23110f20894.tar.xz
sssd-a55e32d1bdb238d3ce3d89212d8da23110f20894.zip
Dereference after null check in sss_idmap_sid_to_unix
https://fedorahosted.org/sssd/ticket/1684
Diffstat (limited to 'src')
-rw-r--r--src/lib/idmap/sss_idmap.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/src/lib/idmap/sss_idmap.c b/src/lib/idmap/sss_idmap.c
index d7254e3ea..3615e9d55 100644
--- a/src/lib/idmap/sss_idmap.c
+++ b/src/lib/idmap/sss_idmap.c
@@ -298,11 +298,15 @@ enum idmap_error_code sss_idmap_sid_to_unix(struct sss_idmap_ctx *ctx,
long long rid;
char *endptr;
+ if (sid == NULL || id == NULL) {
+ return IDMAP_ERROR;
+ }
+
CHECK_IDMAP_CTX(ctx, IDMAP_CONTEXT_INVALID);
idmap_domain_info = ctx->idmap_domain_info;
- if (sid && sss_idmap_sid_is_builtin(sid)) {
+ if (sss_idmap_sid_is_builtin(sid)) {
return IDMAP_BUILTIN_SID;
}