diff options
author | Pavel Reichl <preichl@redhat.com> | 2014-11-28 13:17:44 +0000 |
---|---|---|
committer | Jakub Hrozek <jhrozek@redhat.com> | 2014-11-28 16:16:37 +0100 |
commit | aff8b0e3b41644c70704b78e15501779d52b6ff4 (patch) | |
tree | f0ae0696f623a5bfc36f18f7fea68af904a67f1d /src/util | |
parent | 5b4c6f22cb576a11037c7fa940fe0ba09e643e77 (diff) | |
download | sssd-aff8b0e3b41644c70704b78e15501779d52b6ff4.tar.gz sssd-aff8b0e3b41644c70704b78e15501779d52b6ff4.tar.xz sssd-aff8b0e3b41644c70704b78e15501779d52b6ff4.zip |
Fix: always check return value of unlink()
Resolves:
https://fedorahosted.org/sssd/ticket/2506
Reviewed-by: Lukáš Slebodník <lslebodn@redhat.com>
Diffstat (limited to 'src/util')
-rw-r--r-- | src/util/server.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/src/util/server.c b/src/util/server.c index 03f4b9588..abd29310f 100644 --- a/src/util/server.c +++ b/src/util/server.c @@ -194,8 +194,14 @@ int pidfile(const char *path, const char *name) /* nothing in the file or no process */ close(fd); - unlink(file); - + ret = unlink(file); + /* non-fatal failure */ + if (ret != EOK) { + ret = errno; + DEBUG(SSSDBG_MINOR_FAILURE, + "Failed to remove file: %s - %d [%s]!\n", + file, ret, sss_strerror(ret)); + } } else { if (err != ENOENT) { talloc_free(file); |