diff options
| author | Petr Cech <pcech@redhat.com> | 2015-10-05 10:12:36 -0400 |
|---|---|---|
| committer | Jakub Hrozek <jhrozek@redhat.com> | 2015-10-14 13:27:13 +0200 |
| commit | f8e337540d280f944098cd4dd7d670e2f7166b54 (patch) | |
| tree | 1f1745c2a6859e968f2431a25c0f9d1f2f915764 /src/util | |
| parent | d9c2a21119a6d04203060ad54fa8d20f17f5c0b7 (diff) | |
| download | sssd-f8e337540d280f944098cd4dd7d670e2f7166b54.tar.gz sssd-f8e337540d280f944098cd4dd7d670e2f7166b54.tar.xz sssd-f8e337540d280f944098cd4dd7d670e2f7166b54.zip | |
REFACTOR: umask(077) --> umask(SSS_DFL_X_UMASK)
There are many calls of umask function with 077 argument. This patch
add new constant SSS_DFL_X_UMASK which stands fot 077. So all
occurences of umask(077) are replaced by constant SSS_DFL_X_UMASK.
Resolves:
https://fedorahosted.org/sssd/ticket/2424
Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>
Diffstat (limited to 'src/util')
| -rw-r--r-- | src/util/domain_info_utils.c | 4 | ||||
| -rw-r--r-- | src/util/util.h | 3 |
2 files changed, 5 insertions, 2 deletions
diff --git a/src/util/domain_info_utils.c b/src/util/domain_info_utils.c index ffbb9475b..04e7d08d5 100644 --- a/src/util/domain_info_utils.c +++ b/src/util/domain_info_utils.c @@ -312,7 +312,7 @@ sss_write_domain_mappings(struct sss_domain_info *domain) goto done; } - old_mode = umask(077); + old_mode = umask(SSS_DFL_X_UMASK); fd = mkstemp(tmp_file); umask(old_mode); if (fd < 0) { @@ -562,7 +562,7 @@ static errno_t sss_write_krb5_localauth_snippet(const char *path) goto done; } - old_mode = umask(077); + old_mode = umask(SSS_DFL_X_UMASK); fd = mkstemp(tmp_file); umask(old_mode); if (fd < 0) { diff --git a/src/util/util.h b/src/util/util.h index 9658d79fe..063a97a63 100644 --- a/src/util/util.h +++ b/src/util/util.h @@ -67,6 +67,9 @@ /** Default secure umask */ #define SSS_DFL_UMASK 0177 +/** Secure mask with executable bit */ +#define SSS_DFL_X_UMASK 0077 + extern const char *debug_prg_name; extern int debug_level; extern int debug_timestamps; |