diff options
| author | Jakub Hrozek <jhrozek@redhat.com> | 2014-10-19 12:28:13 +0200 |
|---|---|---|
| committer | Jakub Hrozek <jhrozek@redhat.com> | 2014-11-18 20:33:46 +0100 |
| commit | 35b4b217fa2b91bfc8d58c47024faf41c95fc807 (patch) | |
| tree | 6517adfb61aedb2f721855c3f6b38887b2f1c117 /src/tests | |
| parent | 2745b0156f12df7a7eb93d57716233243658e4d9 (diff) | |
| download | sssd-35b4b217fa2b91bfc8d58c47024faf41c95fc807.tar.gz sssd-35b4b217fa2b91bfc8d58c47024faf41c95fc807.tar.xz sssd-35b4b217fa2b91bfc8d58c47024faf41c95fc807.zip | |
KRB5: Do not switch_creds() if already the specified user
The code didn't have to handle this case previously as sssd_be was always
running as root and switching to the ccache as the user logging in.
Also handle NULL creds on restore_creds() in case there was no switch.
One less if-condition and fewer indentation levels.
Related:
https://fedorahosted.org/sssd/ticket/2370
Reviewed-by: Sumit Bose <sbose@redhat.com>
Reviewed-by: Lukáš Slebodník <lslebodn@redhat.com>
Diffstat (limited to 'src/tests')
| -rw-r--r-- | src/tests/cwrap/test_become_user.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/src/tests/cwrap/test_become_user.c b/src/tests/cwrap/test_become_user.c index 06d3ad425..7ecea5aac 100644 --- a/src/tests/cwrap/test_become_user.c +++ b/src/tests/cwrap/test_become_user.c @@ -76,6 +76,7 @@ void test_switch_user(void **state) struct passwd *sssd; TALLOC_CTX *tmp_ctx; struct sss_creds *saved_creds; + struct sss_creds *saved_creds2 = NULL; check_leaks_push(global_talloc_context); tmp_ctx = talloc_new(global_talloc_context); @@ -102,6 +103,12 @@ void test_switch_user(void **state) assert_int_equal(saved_creds->uid, 0); assert_int_equal(saved_creds->gid, 0); + /* Attempt to restore creds again */ + ret = switch_creds(tmp_ctx, sssd->pw_uid, sssd->pw_gid, + 0, NULL, &saved_creds2); + assert_int_equal(ret, EOK); + assert_null(saved_creds2); + /* restore root */ ret = restore_creds(saved_creds); assert_int_equal(ret, EOK); |