diff options
| author | Lukas Slebodnik <lslebodn@redhat.com> | 2014-09-15 16:05:30 +0200 |
|---|---|---|
| committer | Jakub Hrozek <jhrozek@redhat.com> | 2015-02-11 20:38:42 +0100 |
| commit | 5085d263f2f084778b1314fc5e808668c3758d82 (patch) | |
| tree | da7a12dd45222166481c225963bfedca23aaa115 /src/sss_client | |
| parent | 5594736ea2618bb3e487f47fd199e1d2cf4c58fd (diff) | |
| download | sssd-5085d263f2f084778b1314fc5e808668c3758d82.tar.gz sssd-5085d263f2f084778b1314fc5e808668c3758d82.tar.xz sssd-5085d263f2f084778b1314fc5e808668c3758d82.zip | |
Fix warning: equality comparison with extraneous parentheses
Example of warning:
src/sss_client/libwbclient/wbc_pwd_sssd.c:246:23:
error: equality comparison with extraneous parentheses
[-Werror,-Wparentheses-equality]
if (((wbc_status) == WBC_ERR_SUCCESS)) {
~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
src/sss_client/libwbclient/wbc_pwd_sssd.c:246:23:
note: remove extraneous parentheses around the comparison
to silence this warning
if (((wbc_status) == WBC_ERR_SUCCESS)) {
~ ^ ~
src/sss_client/libwbclient/wbc_pwd_sssd.c:246:23:
note: use '=' to turn this equality comparison into an assignment
if (((wbc_status) == WBC_ERR_SUCCESS)) {
^~
=
The reason is definition of some macros which were used in if conditions.
Reviewed-by: Michal Židek <mzidek@redhat.com>
Diffstat (limited to 'src/sss_client')
| -rw-r--r-- | src/sss_client/libwbclient/wbc_pwd_sssd.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/src/sss_client/libwbclient/wbc_pwd_sssd.c b/src/sss_client/libwbclient/wbc_pwd_sssd.c index 6cdea1c03..08c3b8637 100644 --- a/src/sss_client/libwbclient/wbc_pwd_sssd.c +++ b/src/sss_client/libwbclient/wbc_pwd_sssd.c @@ -243,7 +243,7 @@ wbcErr wbcGetpwnam(const char *name, struct passwd **pwd) status = ctx->getpwnam_r(name, &lpwd, buffer, buflen, &nss_errno); wbc_status = nss_to_wbc(status); - if (WBC_ERROR_IS_OK(wbc_status)) { + if (WBC_ERROR_IS_OK(wbc_status) == true) { wbc_status = copy_pwd(&lpwd, pwd); } @@ -278,7 +278,7 @@ wbcErr wbcGetpwuid(uid_t uid, struct passwd **pwd) status = ctx->getpwuid_r(uid, &lpwd, buffer, buflen, &nss_errno); wbc_status = nss_to_wbc(status); - if (WBC_ERROR_IS_OK(wbc_status)) { + if (WBC_ERROR_IS_OK(wbc_status) == true) { wbc_status = copy_pwd(&lpwd, pwd); } @@ -401,7 +401,7 @@ wbcErr wbcGetgrnam(const char *name, struct group **grp) memset(grp, 0, sizeof(struct group)); status = ctx->getgrnam_r(name, &lgrp, buffer, buflen, &nss_errno); wbc_status = nss_to_wbc(status); - if (WBC_ERROR_IS_OK(wbc_status)) { + if (WBC_ERROR_IS_OK(wbc_status) == true) { wbc_status = copy_grp(&lgrp, grp); } } while (status == NSS_STATUS_TRYAGAIN && nss_errno == ERANGE \ @@ -445,7 +445,7 @@ wbcErr wbcGetgrgid(gid_t gid, struct group **grp) memset(grp, 0, sizeof(struct group)); status = ctx->getgrgid_r(gid, &lgrp, buffer, buflen, &nss_errno); wbc_status = nss_to_wbc(status); - if (WBC_ERROR_IS_OK(wbc_status)) { + if (WBC_ERROR_IS_OK(wbc_status) == true) { wbc_status = copy_grp(&lgrp, grp); } } while (status == NSS_STATUS_TRYAGAIN && nss_errno == ERANGE \ @@ -514,7 +514,7 @@ wbcErr wbcGetpwent(struct passwd **pwd) status = ctx->getpwent_r(&lpwd, buffer, buflen, &nss_errno); wbc_status = nss_to_wbc(status); - if (WBC_ERROR_IS_OK(wbc_status)) { + if (WBC_ERROR_IS_OK(wbc_status) == true) { wbc_status = copy_pwd(&lpwd, pwd); } @@ -588,7 +588,7 @@ wbcErr wbcGetgrent(struct group **grp) memset(grp, 0, sizeof(struct group)); status = ctx->getgrent_r(&lgrp, buffer, buflen, &nss_errno); wbc_status = nss_to_wbc(status); - if (WBC_ERROR_IS_OK(wbc_status)) { + if (WBC_ERROR_IS_OK(wbc_status) == true) { wbc_status = copy_grp(&lgrp, grp); } } while (status == NSS_STATUS_TRYAGAIN && nss_errno == ERANGE \ |