summaryrefslogtreecommitdiffstats
path: root/src/responder
diff options
context:
space:
mode:
authorPavel Březina <pbrezina@redhat.com>2012-01-12 09:41:52 +0100
committerStephen Gallagher <sgallagh@redhat.com>2012-01-17 11:38:15 -0500
commitf643754db81eeade60485bbe3d80324d889cc4f3 (patch)
tree7810f368bf11fdc3ea98f9de642dd3ef0fca3271 /src/responder
parent2be3039b8fc8ec07a323d15060123366da786dc5 (diff)
downloadsssd-f643754db81eeade60485bbe3d80324d889cc4f3.tar.gz
sssd-f643754db81eeade60485bbe3d80324d889cc4f3.tar.xz
sssd-f643754db81eeade60485bbe3d80324d889cc4f3.zip
SUDO Integration review issues
Diffstat (limited to 'src/responder')
-rw-r--r--src/responder/sudo/sudosrv_dp.c2
-rw-r--r--src/responder/sudo/sudosrv_get_sudorules.c3
2 files changed, 4 insertions, 1 deletions
diff --git a/src/responder/sudo/sudosrv_dp.c b/src/responder/sudo/sudosrv_dp.c
index 0c621f5d5..27f01f92b 100644
--- a/src/responder/sudo/sudosrv_dp.c
+++ b/src/responder/sudo/sudosrv_dp.c
@@ -107,6 +107,8 @@ struct tevent_req * sudosrv_dp_refresh_send(struct resp_ctx *rctx,
error:
tevent_req_error(req, ret);
tevent_req_post(req, rctx->ev);
+ dbus_message_unref(msg);
+
return req;
}
diff --git a/src/responder/sudo/sudosrv_get_sudorules.c b/src/responder/sudo/sudosrv_get_sudorules.c
index 5d54f95ab..fca6257d8 100644
--- a/src/responder/sudo/sudosrv_get_sudorules.c
+++ b/src/responder/sudo/sudosrv_get_sudorules.c
@@ -481,7 +481,8 @@ char * sudosrv_get_sudorules_parse_query(TALLOC_CTX *mem_ctx,
const char *query_body,
int query_len)
{
- if (query_len < 2 || ((query_len - 1) != strlen(query_body))) {
+ /* empty string or not NULL terminated */
+ if (query_len < 2 || strnlen(query_body, query_len) == query_len) {
DEBUG(SSSDBG_CRIT_FAILURE, ("Invalid query.\n"));
return NULL;
}