diff options
author | Pavel Reichl <preichl@redhat.com> | 2014-11-28 13:17:44 +0000 |
---|---|---|
committer | Jakub Hrozek <jhrozek@redhat.com> | 2014-11-28 16:16:37 +0100 |
commit | aff8b0e3b41644c70704b78e15501779d52b6ff4 (patch) | |
tree | f0ae0696f623a5bfc36f18f7fea68af904a67f1d /src/responder | |
parent | 5b4c6f22cb576a11037c7fa940fe0ba09e643e77 (diff) | |
download | sssd-aff8b0e3b41644c70704b78e15501779d52b6ff4.tar.gz sssd-aff8b0e3b41644c70704b78e15501779d52b6ff4.tar.xz sssd-aff8b0e3b41644c70704b78e15501779d52b6ff4.zip |
Fix: always check return value of unlink()
Resolves:
https://fedorahosted.org/sssd/ticket/2506
Reviewed-by: Lukáš Slebodník <lslebodn@redhat.com>
Diffstat (limited to 'src/responder')
-rw-r--r-- | src/responder/ssh/sshsrv_cmd.c | 14 |
1 files changed, 12 insertions, 2 deletions
diff --git a/src/responder/ssh/sshsrv_cmd.c b/src/responder/ssh/sshsrv_cmd.c index 5bed2e0ad..e7bed3ab2 100644 --- a/src/responder/ssh/sshsrv_cmd.c +++ b/src/responder/ssh/sshsrv_cmd.c @@ -536,7 +536,7 @@ static errno_t ssh_host_pubkeys_update_known_hosts(struct ssh_cmd_ctx *cmd_ctx) { TALLOC_CTX *tmp_ctx; - errno_t ret; + errno_t ret, tmp_ret; const char *attrs[] = { SYSDB_NAME, SYSDB_NAME_ALIAS, @@ -654,7 +654,17 @@ ssh_host_pubkeys_update_known_hosts(struct ssh_cmd_ctx *cmd_ctx) done: if (fd != -1) close(fd); - if (ret != EOK && filename) unlink(filename); + if (ret != EOK && filename) { + tmp_ret = unlink(filename); + /* non-fatal failure */ + if (tmp_ret != EOK) { + tmp_ret = errno; + DEBUG(SSSDBG_MINOR_FAILURE, + "Failed to remove file: %s - %d : [%s]!\n", + filename, tmp_ret, sss_strerror(tmp_ret)); + } + } + talloc_free(tmp_ctx); return ret; |