diff options
| author | Jakub Hrozek <jhrozek@redhat.com> | 2011-02-15 14:16:13 +0100 |
|---|---|---|
| committer | Stephen Gallagher <sgallagh@redhat.com> | 2011-04-08 11:32:23 -0400 |
| commit | df33bc1ede96f57f2b8be1fa6f8a1f7451bf051f (patch) | |
| tree | 6a24201d0c075dd13459ec8f888336edc5c5ab2c /src/responder/pam | |
| parent | 4a28fb10122bd74ba33607af46f028813de9161d (diff) | |
| download | sssd-df33bc1ede96f57f2b8be1fa6f8a1f7451bf051f.tar.gz sssd-df33bc1ede96f57f2b8be1fa6f8a1f7451bf051f.tar.xz sssd-df33bc1ede96f57f2b8be1fa6f8a1f7451bf051f.zip | |
Fix unchecked return values of pam_add_response
https://fedorahosted.org/sssd/ticket/798
Diffstat (limited to 'src/responder/pam')
| -rw-r--r-- | src/responder/pam/pamsrv_cmd.c | 16 |
1 files changed, 12 insertions, 4 deletions
diff --git a/src/responder/pam/pamsrv_cmd.c b/src/responder/pam/pamsrv_cmd.c index 8035a6878..3c9d7600a 100644 --- a/src/responder/pam/pamsrv_cmd.c +++ b/src/responder/pam/pamsrv_cmd.c @@ -500,8 +500,12 @@ static void pam_reply(struct pam_auth_req *preq) DEBUG(5, ("Password change not possible while offline.\n")); pd->pam_status = PAM_AUTHTOK_ERR; user_info_type = SSS_PAM_USER_INFO_OFFLINE_CHPASS; - pam_add_response(pd, SSS_PAM_USER_INFO, sizeof(uint32_t), - (const uint8_t *) &user_info_type); + ret = pam_add_response(pd, SSS_PAM_USER_INFO, sizeof(uint32_t), + (const uint8_t *) &user_info_type); + if (ret != EOK) { + DEBUG(1, ("pam_add_response failed.\n")); + goto done; + } break; /* TODO: we need the pam session cookie here to make sure that cached * authentication was successful */ @@ -565,8 +569,12 @@ static void pam_reply(struct pam_auth_req *preq) } if (pd->domain != NULL) { - pam_add_response(pd, SSS_PAM_DOMAIN_NAME, strlen(pd->domain)+1, - (uint8_t *) pd->domain); + ret = pam_add_response(pd, SSS_PAM_DOMAIN_NAME, strlen(pd->domain)+1, + (uint8_t *) pd->domain); + if (ret != EOK) { + DEBUG(1, ("pam_add_response failed.\n")); + goto done; + } } resp_c = 0; |