summaryrefslogtreecommitdiffstats
path: root/src/responder/pac/pacsrv_cmd.c
diff options
context:
space:
mode:
authorSumit Bose <sbose@redhat.com>2013-04-19 17:44:26 +0200
committerJakub Hrozek <jhrozek@redhat.com>2013-04-21 10:22:36 +0200
commitd29d5d9e0e9ee0396a46f4375092644f29024f25 (patch)
treec63f36fcf55ad7bde8b8c5f11dab9612d6b7676c /src/responder/pac/pacsrv_cmd.c
parent18f01e63c1968c29bddb9e48c279b583c0444730 (diff)
downloadsssd-d29d5d9e0e9ee0396a46f4375092644f29024f25.tar.gz
sssd-d29d5d9e0e9ee0396a46f4375092644f29024f25.tar.xz
sssd-d29d5d9e0e9ee0396a46f4375092644f29024f25.zip
Fix and rename get_my_domain_data()
The task of get_my_domain_data() is to read some information about the configured domain from the cache. While the sysdb interface was redesigned some changes changed the behaviour so that the data of the domain of the current request was read. If this domain is a sub-domain the wrong data was read. As a result group-memberships of the configured domain were not taken into account. The original code didn't made it easy to see that always the parent domain should be used here, because there was no comment indication this and the function name get_my_domain_data() didn't made it clear either. Additionally to fixing the issue this patch also adds a comment and rename the function to get_parent_domain_data(). Fixes https://fedorahosted.org/sssd/ticket/1888
Diffstat (limited to 'src/responder/pac/pacsrv_cmd.c')
-rw-r--r--src/responder/pac/pacsrv_cmd.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/responder/pac/pacsrv_cmd.c b/src/responder/pac/pacsrv_cmd.c
index a8b272e78..ac49a0e7c 100644
--- a/src/responder/pac/pacsrv_cmd.c
+++ b/src/responder/pac/pacsrv_cmd.c
@@ -225,10 +225,10 @@ static errno_t pac_add_user_next(struct pac_req_ctx *pr_ctx)
goto done;
}
- ret = get_my_domain_data(pr_ctx->pac_ctx, pr_ctx->dom,
- &my_dom_sid, &my_range_map);
+ ret = get_parent_domain_data(pr_ctx->pac_ctx, pr_ctx->dom,
+ &my_dom_sid, &my_range_map);
if (ret != EOK) {
- DEBUG(SSSDBG_OP_FAILURE, ("get_my_domain_sid failed.\n"));
+ DEBUG(SSSDBG_OP_FAILURE, ("get_parent_domain_data failed.\n"));
goto done;
}