summaryrefslogtreecommitdiffstats
path: root/src/providers
diff options
context:
space:
mode:
authorJakub Hrozek <jhrozek@redhat.com>2013-01-15 07:54:03 +0100
committerJakub Hrozek <jhrozek@redhat.com>2013-01-16 17:02:08 +0100
commita40f572fb5022b1f1e121267e91ceb0e370602a9 (patch)
treeab35d402706b55a63a51c7e3b475d2fdc89f064b /src/providers
parent11d0cb5bec7e023ed1903487af42d417d64dd2e9 (diff)
downloadsssd-a40f572fb5022b1f1e121267e91ceb0e370602a9.tar.gz
sssd-a40f572fb5022b1f1e121267e91ceb0e370602a9.tar.xz
sssd-a40f572fb5022b1f1e121267e91ceb0e370602a9.zip
Invalidate user entry even if there are no groups
Related to https://fedorahosted.org/sssd/ticket/1757 Previously we would optimize the mc invalidate code for cases where the user was a member of some groups. But if the user was removed from the server while being in memory cache, we would only invalidate the mc record if he was a member of at least one supplementary group.
Diffstat (limited to 'src/providers')
-rw-r--r--src/providers/data_provider_be.c12
1 files changed, 7 insertions, 5 deletions
diff --git a/src/providers/data_provider_be.c b/src/providers/data_provider_be.c
index ce16aeb69..b261bf8d4 100644
--- a/src/providers/data_provider_be.c
+++ b/src/providers/data_provider_be.c
@@ -669,9 +669,9 @@ static errno_t be_initgroups_prereq(struct be_req *be_req)
if (ret && ret != ENOENT) {
return ret;
}
- /* if the user is completely missing or has no group memberships
- * at all there is no need to contact NSS, it would be a noop */
- if (ret == ENOENT || res->count == 0 || res->count == 1) {
+ /* if the user is completely missing there is no need to contact NSS,
+ * it would be a noop */
+ if (ret == ENOENT || res->count == 0) {
/* yet unknown, ignore */
return EOK;
}
@@ -680,7 +680,7 @@ static errno_t be_initgroups_prereq(struct be_req *be_req)
if (!pr) {
return ENOMEM;
}
- pr->groups = talloc_array(pr, gid_t, res->count - 1);
+ pr->groups = talloc_array(pr, gid_t, res->count);
if (!pr->groups) {
return ENOMEM;
}
@@ -696,7 +696,9 @@ static errno_t be_initgroups_prereq(struct be_req *be_req)
if (!pr->domain) {
return ENOMEM;
}
- for (pr->gnum = 0, i = 1; i < res->count; i++) {
+ /* The first GID is the primary so it might be duplicated
+ * later in the list */
+ for (pr->gnum = 0, i = 0; i < res->count; i++) {
pr->groups[pr->gnum] = ldb_msg_find_attr_as_uint(res->msgs[i],
SYSDB_GIDNUM, 0);
/* if 0 it may be a non-posix group, so we skip it */