diff options
| author | Jakub Hrozek <jhrozek@redhat.com> | 2011-02-15 14:16:13 +0100 |
|---|---|---|
| committer | Stephen Gallagher <sgallagh@redhat.com> | 2011-07-05 13:41:13 -0400 |
| commit | 24d319721a43101d996034442137bae37b007fd3 (patch) | |
| tree | 729dad1b10775b4405a4039a1a8c582d9c4d8a39 /src/providers | |
| parent | 90f5a8a2bffb96c03097e7134388f63a72decdb5 (diff) | |
| download | sssd-24d319721a43101d996034442137bae37b007fd3.tar.gz sssd-24d319721a43101d996034442137bae37b007fd3.tar.xz sssd-24d319721a43101d996034442137bae37b007fd3.zip | |
Fix unchecked return values of pam_add_responsesssd-1_5_11
https://fedorahosted.org/sssd/ticket/798
Diffstat (limited to 'src/providers')
| -rw-r--r-- | src/providers/dp_auth_util.c | 5 | ||||
| -rw-r--r-- | src/providers/ldap/ldap_auth.c | 9 |
2 files changed, 11 insertions, 3 deletions
diff --git a/src/providers/dp_auth_util.c b/src/providers/dp_auth_util.c index f8730cf91..7c3541b0c 100644 --- a/src/providers/dp_auth_util.c +++ b/src/providers/dp_auth_util.c @@ -255,7 +255,10 @@ bool dp_unpack_pam_response(DBusMessage *msg, struct pam_data *pd, DBusError *db dbus_message_iter_recurse(&struct_iter, &sub_iter); dbus_message_iter_get_fixed_array(&sub_iter, &data, &len); - pam_add_response(pd, type, len, data); + if (pam_add_response(pd, type, len, data) != EOK) { + DEBUG(1, ("pam_add_response failed.\n")); + return false; + } dbus_message_iter_next(&array_iter); } diff --git a/src/providers/ldap/ldap_auth.c b/src/providers/ldap/ldap_auth.c index 6970d7f69..5857e5379 100644 --- a/src/providers/ldap/ldap_auth.c +++ b/src/providers/ldap/ldap_auth.c @@ -206,6 +206,7 @@ static errno_t check_pwexpire_ldap(struct pam_data *pd, if (ppolicy->grace > 0 || ppolicy->expire > 0) { uint32_t *data; uint32_t *ptr; + int ret; data = talloc_size(pd, 2* sizeof(uint32_t)); if (data == NULL) { @@ -224,8 +225,12 @@ static errno_t check_pwexpire_ldap(struct pam_data *pd, *ptr = ppolicy->expire; } - pam_add_response(pd, SSS_PAM_USER_INFO, 2* sizeof(uint32_t), - (uint8_t*)data); + ret = pam_add_response(pd, SSS_PAM_USER_INFO, 2* sizeof(uint32_t), + (uint8_t*)data); + if (ret != EOK) { + DEBUG(1, ("pam_add_response failed.\n")); + return ret; + } } *result = SDAP_AUTH_SUCCESS; |