summaryrefslogtreecommitdiffstats
path: root/src/providers
diff options
context:
space:
mode:
authorJakub Hrozek <jhrozek@redhat.com>2014-04-15 17:32:38 +0200
committerJakub Hrozek <jhrozek@redhat.com>2014-04-22 17:29:40 +0200
commitef2455b63380ecd17bea94270ceaabe15dcf6456 (patch)
treee04d0c7901eb59cd469b056a704de3d355658d46 /src/providers
parentc5a554f46f8ca0fd09afdb1f53dd9e229a68b86f (diff)
downloadsssd-ef2455b63380ecd17bea94270ceaabe15dcf6456.tar.gz
sssd-ef2455b63380ecd17bea94270ceaabe15dcf6456.tar.xz
sssd-ef2455b63380ecd17bea94270ceaabe15dcf6456.zip
DP: Remove unused 'force' parameter from the subdomain handler
The force argument was unused and made the code more complex than required. Moreover, the force argument would have made the subdomain handler behave differently than other identity domains -- when the front end decides it's time to update the domains, the back end should just update them. Handling multiple concurrent requests from multiple responders (typically after startup) is handled at the generic back end level (see be_queue_request). Reviewed-by: Pavel Březina <pbrezina@redhat.com>
Diffstat (limited to 'src/providers')
-rw-r--r--src/providers/data_provider_be.c8
1 files changed, 2 insertions, 6 deletions
diff --git a/src/providers/data_provider_be.c b/src/providers/data_provider_be.c
index 5c2b480db..ec2c0fa5d 100644
--- a/src/providers/data_provider_be.c
+++ b/src/providers/data_provider_be.c
@@ -564,7 +564,6 @@ static int be_get_subdomains(struct sbus_request *dbus_req, void *user_data)
struct be_subdom_req *req;
struct be_req *be_req = NULL;
struct be_client *becli;
- dbus_bool_t force;
char *domain_hint;
dbus_uint16_t err_maj;
dbus_uint32_t err_min;
@@ -575,7 +574,6 @@ static int be_get_subdomains(struct sbus_request *dbus_req, void *user_data)
if (!becli) return EINVAL;
if (!sbus_request_parse_or_finish(dbus_req,
- DBUS_TYPE_BOOLEAN, &force,
DBUS_TYPE_STRING, &domain_hint,
DBUS_TYPE_INVALID))
return EOK; /* handled */
@@ -589,9 +587,8 @@ static int be_get_subdomains(struct sbus_request *dbus_req, void *user_data)
goto immediate;
}
- DEBUG(SSSDBG_TRACE_FUNC,
- "Got get subdomains [%sforced][%s]\n", force ? "" : "not ",
- domain_hint == NULL ? "no hint": domain_hint );
+ DEBUG(SSSDBG_TRACE_FUNC, "Got get subdomains [%s]\n",
+ domain_hint == NULL ? "no hint": domain_hint );
/* If we are offline return immediately
*/
@@ -621,7 +618,6 @@ static int be_get_subdomains(struct sbus_request *dbus_req, void *user_data)
err_msg = "Out of memory";
goto immediate;
}
- req->force = force;
req->domain_hint = talloc_strdup(req, domain_hint);
if (!req->domain_hint) {
err_maj = DP_ERR_FATAL;