Add missing new lines to debug messages

Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>

19 files changed, 46 insertions, 44 deletions

diff --git a/src/providers/ad/ad_common.c b/src/providers/ad/ad_common.c
index c3cbfdac0..120878977 100644
--- a/src/providers/ad/ad_common.c
+++ b/src/providers/ad/ad_common.c
@@ -437,8 +437,8 @@ _ad_servers_init(struct ad_service *service,
                                        false, sdata);
             if (ret != EOK) {
                 DEBUG(SSSDBG_FATAL_FAILURE,
-                      "Failed to add service discovery to failover: [%s]",
-                       strerror(ret));
+                      "Failed to add service discovery to failover: [%s]\n",
+                      strerror(ret));
                 goto done;
             }
 
@@ -454,8 +454,8 @@ _ad_servers_init(struct ad_service *service,
                                        false, sdata);
             if (ret != EOK) {
                 DEBUG(SSSDBG_FATAL_FAILURE,
-                      "Failed to add service discovery to failover: [%s]",
-                       strerror(ret));
+                      "Failed to add service discovery to failover: [%s]\n",
+                      strerror(ret));
                 goto done;
             }
 
diff --git a/src/providers/ad/ad_init.c b/src/providers/ad/ad_init.c
index ca2d49f62..3d12f382c 100644
--- a/src/providers/ad/ad_init.c
+++ b/src/providers/ad/ad_init.c
@@ -454,16 +454,16 @@ sssm_ad_access_init(struct be_ctx *bectx,
     ret = sss_hash_create(access_ctx, 10, &access_ctx->gpo_map_options_table);
     if (ret != EOK) {
         DEBUG(SSSDBG_FATAL_FAILURE,
-              "Could not create gpo_map_options hash table: [%s]",
-               strerror(ret));
+              "Could not create gpo_map_options hash table: [%s]\n",
+              strerror(ret));
         goto fail;
     }
 
     ret = ad_gpo_parse_map_options(access_ctx);
     if (ret != EOK) {
         DEBUG(SSSDBG_FATAL_FAILURE,
-              "Could not parse gpo_map_options (invalid config): [%s]",
-               strerror(ret));
+              "Could not parse gpo_map_options (invalid config): [%s]\n",
+              strerror(ret));
         goto fail;
     }
 
diff --git a/src/providers/ad/ad_subdomains.c b/src/providers/ad/ad_subdomains.c
index b3821f8d0..5a6e9338d 100644
--- a/src/providers/ad/ad_subdomains.c
+++ b/src/providers/ad/ad_subdomains.c
@@ -1186,12 +1186,12 @@ int ad_subdom_init(struct be_ctx *be_ctx,
 
     ret = be_add_online_cb(ctx, be_ctx, ad_subdom_online_cb, ctx, NULL);
     if (ret != EOK) {
-        DEBUG(SSSDBG_MINOR_FAILURE, "Failed to add subdom online callback");
+        DEBUG(SSSDBG_MINOR_FAILURE, "Failed to add subdom online callback\n");
     }
 
     ret = be_add_offline_cb(ctx, be_ctx, ad_subdom_offline_cb, ctx, NULL);
     if (ret != EOK) {
-        DEBUG(SSSDBG_MINOR_FAILURE, "Failed to add subdom offline callback");
+        DEBUG(SSSDBG_MINOR_FAILURE, "Failed to add subdom offline callback\n");
     }
 
     err = sss_idmap_init(sss_idmap_talloc, ctx, sss_idmap_talloc_free,
diff --git a/src/providers/data_provider_be.c b/src/providers/data_provider_be.c
index 47809e20f..a48a42878 100644
--- a/src/providers/data_provider_be.c
+++ b/src/providers/data_provider_be.c
@@ -927,7 +927,7 @@ be_file_account_request(struct be_req *be_req, struct be_acct_req *ar)
     if ((ar->entry_type & 0xFF) == BE_REQ_INITGROUPS) {
         ret = be_initgroups_prereq(be_req);
         if (ret) {
-            DEBUG(SSSDBG_CRIT_FAILURE, "Prerequest failed");
+            DEBUG(SSSDBG_CRIT_FAILURE, "Prerequest failed\n");
             return ret;
         }
     }
@@ -936,7 +936,7 @@ be_file_account_request(struct be_req *be_req, struct be_acct_req *ar)
     ret = be_file_request(be_ctx, be_req,
                           be_ctx->bet_info[BET_ID].bet_ops->handler);
     if (ret != EOK) {
-        DEBUG(SSSDBG_CRIT_FAILURE, "Failed to file request");
+        DEBUG(SSSDBG_CRIT_FAILURE, "Failed to file request\n");
         return ret;
     }
 
diff --git a/src/providers/dp_dyndns.c b/src/providers/dp_dyndns.c
index 580fb2c63..7db21509d 100644
--- a/src/providers/dp_dyndns.c
+++ b/src/providers/dp_dyndns.c
@@ -475,10 +475,10 @@ be_nsupdate_create_fwd_msg(TALLOC_CTX *mem_ctx, const char *realm,
     }
 
     DEBUG(SSSDBG_TRACE_FUNC,
-          " -- Begin nsupdate message -- \n%s",
-           update_msg);
-    DEBUG(SSSDBG_TRACE_FUNC,
-          " -- End nsupdate message -- \n");
+          " -- Begin nsupdate message -- \n"
+          "%s"
+          " -- End nsupdate message -- \n",
+          update_msg);
 
     ret = ERR_OK;
     *_update_msg = talloc_steal(mem_ctx, update_msg);
@@ -517,10 +517,10 @@ be_nsupdate_create_ptr_msg(TALLOC_CTX *mem_ctx, const char *realm,
     }
 
     DEBUG(SSSDBG_TRACE_FUNC,
-          " -- Begin nsupdate message -- \n%s",
-           update_msg);
-    DEBUG(SSSDBG_TRACE_FUNC,
-          " -- End nsupdate message -- \n");
+          " -- Begin nsupdate message -- \n"
+          "%s"
+          " -- End nsupdate message -- \n",
+          update_msg);
 
     ret = ERR_OK;
     *_update_msg = talloc_steal(mem_ctx, update_msg);
diff --git a/src/providers/dp_ptask.c b/src/providers/dp_ptask.c
index e3450851e..0f28dee1e 100644
--- a/src/providers/dp_ptask.c
+++ b/src/providers/dp_ptask.c
@@ -317,15 +317,17 @@ errno_t be_ptask_create(TALLOC_CTX *mem_ctx,
         /* install offline and online callbacks */
         ret = be_add_online_cb(task, be_ctx, be_ptask_online_cb, task, NULL);
         if (ret != EOK) {
-            DEBUG(SSSDBG_OP_FAILURE, "Unable to install online callback "
-                                      "[%d]: %s", ret, sss_strerror(ret));
+            DEBUG(SSSDBG_OP_FAILURE,
+                  "Unable to install online callback [%d]: %s\n",
+                  ret, sss_strerror(ret));
             goto done;
         }
 
         ret = be_add_offline_cb(task, be_ctx, be_ptask_offline_cb, task, NULL);
         if (ret != EOK) {
-            DEBUG(SSSDBG_OP_FAILURE, "Unable to install offline callback "
-                                      "[%d]: %s", ret, sss_strerror(ret));
+            DEBUG(SSSDBG_OP_FAILURE,
+                  "Unable to install offline callback [%d]: %s\n",
+                  ret, sss_strerror(ret));
             goto done;
         }
     }
diff --git a/src/providers/ipa/ipa_access.c b/src/providers/ipa/ipa_access.c
index ed52132ad..2ebaec337 100644
--- a/src/providers/ipa/ipa_access.c
+++ b/src/providers/ipa/ipa_access.c
@@ -711,7 +711,7 @@ errno_t hbac_get_cached_rules(TALLOC_CTX *mem_ctx,
                               HBAC_RULES_SUBDIR, attrs,
                               &rule_count, &msgs);
     if (ret != EOK && ret != ENOENT) {
-        DEBUG(SSSDBG_CRIT_FAILURE, "Error looking up HBAC rules");
+        DEBUG(SSSDBG_CRIT_FAILURE, "Error looking up HBAC rules\n");
         goto done;
     } if (ret == ENOENT) {
        rule_count = 0;
diff --git a/src/providers/ipa/ipa_hbac_rules.c b/src/providers/ipa/ipa_hbac_rules.c
index 571b90c58..497eee612 100644
--- a/src/providers/ipa/ipa_hbac_rules.c
+++ b/src/providers/ipa/ipa_hbac_rules.c
@@ -144,7 +144,7 @@ ipa_hbac_rule_info_send(TALLOC_CTX *mem_ctx,
     ret = sysdb_attrs_get_string_array(ipa_host, SYSDB_ORIG_MEMBEROF,
                                        tmp_ctx, &memberof_list);
     if (ret != EOK && ret != ENOENT) {
-        DEBUG(SSSDBG_CRIT_FAILURE, "Could not identify ");
+        DEBUG(SSSDBG_CRIT_FAILURE, "Could not identify.\n");
     } if (ret == ENOENT) {
         /* This host is not a member of any hostgroups */
         memberof_list = talloc_array(tmp_ctx, const char *, 1);
diff --git a/src/providers/ipa/ipa_hostid.c b/src/providers/ipa/ipa_hostid.c
index 6b8233587..31fa29f91 100644
--- a/src/providers/ipa/ipa_hostid.c
+++ b/src/providers/ipa/ipa_hostid.c
@@ -110,7 +110,7 @@ ipa_host_info_complete(struct be_req *breq, int dp_error,
             error_text = NULL;
         } else {
             DEBUG(SSSDBG_CRIT_FAILURE,
-                  "Bug: dp_error is OK on failed request");
+                  "Bug: dp_error is OK on failed request\n");
             dp_error = DP_ERR_FATAL;
             error_text = default_error_text;
         }
diff --git a/src/providers/ipa/ipa_selinux.c b/src/providers/ipa/ipa_selinux.c
index aa53769e3..0555cdd50 100644
--- a/src/providers/ipa/ipa_selinux.c
+++ b/src/providers/ipa/ipa_selinux.c
@@ -211,7 +211,7 @@ done:
     if (in_transaction) {
         sret = sysdb_transaction_cancel(sysdb);
         if (sret != EOK) {
-            DEBUG(SSSDBG_CRIT_FAILURE, "Failed to cancel transaction");
+            DEBUG(SSSDBG_CRIT_FAILURE, "Failed to cancel transaction\n");
         }
     }
     return ret;
@@ -788,7 +788,7 @@ static errno_t choose_best_seuser(TALLOC_CTX *mem_ctx,
 
     ret = selinux_child_setup(tmp_ctx, pd->user, user_domain, seuser_mls_str, &sci);
     if (ret != EOK) {
-        DEBUG(SSSDBG_OP_FAILURE, "Cannot set up child input buffer");
+        DEBUG(SSSDBG_OP_FAILURE, "Cannot set up child input buffer\n");
         goto done;
     }
 
@@ -865,7 +865,7 @@ selinux_child_setup(TALLOC_CTX *mem_ctx,
             }
         } else {
             DEBUG(SSSDBG_OP_FAILURE,
-                  "sss_parse_name failed: [%d] %s", ret, sss_strerror(ret));
+                  "sss_parse_name failed: [%d] %s\n", ret, sss_strerror(ret));
             goto done;
         }
     } else {
diff --git a/src/providers/ipa/ipa_subdomains.c b/src/providers/ipa/ipa_subdomains.c
index d0f02bade..0fe2a8dd6 100644
--- a/src/providers/ipa/ipa_subdomains.c
+++ b/src/providers/ipa/ipa_subdomains.c
@@ -1658,17 +1658,17 @@ int ipa_subdom_init(struct be_ctx *be_ctx,
                                          NULL);
     if (ret != EOK) {
         DEBUG(SSSDBG_MINOR_FAILURE,
-              "Failed to add subdom reset timeouts callback");
+              "Failed to add subdom reset timeouts callback\n");
     }
 
     ret = be_add_online_cb(ctx, be_ctx, ipa_subdom_online_cb, ctx, NULL);
     if (ret != EOK) {
-        DEBUG(SSSDBG_MINOR_FAILURE, "Failed to add subdom online callback");
+        DEBUG(SSSDBG_MINOR_FAILURE, "Failed to add subdom online callback\n");
     }
 
     ret = be_add_offline_cb(ctx, be_ctx, ipa_subdom_offline_cb, ctx, NULL);
     if (ret != EOK) {
-        DEBUG(SSSDBG_MINOR_FAILURE, "Failed to add subdom offline callback");
+        DEBUG(SSSDBG_MINOR_FAILURE, "Failed to add subdom offline callback\n");
     }
 
     ret = ipa_subdom_reinit(ctx);
diff --git a/src/providers/krb5/krb5_child.c b/src/providers/krb5/krb5_child.c
index 6c690145d..8fb2e6b2f 100644
--- a/src/providers/krb5/krb5_child.c
+++ b/src/providers/krb5/krb5_child.c
@@ -947,7 +947,7 @@ done:
     }
 
     if (krb5_kt_close(kr->ctx, keytab) != 0) {
-        DEBUG(SSSDBG_MINOR_FAILURE, "krb5_kt_close failed");
+        DEBUG(SSSDBG_MINOR_FAILURE, "krb5_kt_close failed\n");
     }
     if (validation_princ != NULL) {
         krb5_free_principal(kr->ctx, validation_princ);
diff --git a/src/providers/krb5/krb5_wait_queue.c b/src/providers/krb5/krb5_wait_queue.c
index 3c390531e..10c50d81b 100644
--- a/src/providers/krb5/krb5_wait_queue.c
+++ b/src/providers/krb5/krb5_wait_queue.c
@@ -84,7 +84,7 @@ errno_t add_to_wait_queue(struct be_req *be_req, struct pam_data *pd,
                                  &krb5_ctx->wait_queue_hash, 0, 0, 0, 0,
                                  wait_queue_del_cb, NULL);
         if (ret != EOK) {
-            DEBUG(SSSDBG_CRIT_FAILURE, "sss_hash_create failed");
+            DEBUG(SSSDBG_CRIT_FAILURE, "sss_hash_create failed\n");
             return ret;
         }
     }
diff --git a/src/providers/ldap/ldap_id.c b/src/providers/ldap/ldap_id.c
index e60e3a53a..642ae5c29 100644
--- a/src/providers/ldap/ldap_id.c
+++ b/src/providers/ldap/ldap_id.c
@@ -1640,7 +1640,7 @@ static void sdap_account_info_complete(struct tevent_req *req)
             error_text = NULL;
         } else {
             DEBUG(SSSDBG_CRIT_FAILURE,
-                  "Bug: dp_error is OK on failed request");
+                  "Bug: dp_error is OK on failed request\n");
             dp_error = DP_ERR_FATAL;
             error_text = req_error_text;
         }
diff --git a/src/providers/ldap/sdap.c b/src/providers/ldap/sdap.c
index c401e7dc8..bae7d02c5 100644
--- a/src/providers/ldap/sdap.c
+++ b/src/providers/ldap/sdap.c
@@ -437,7 +437,7 @@ int sdap_parse_entry(TALLOC_CTX *memctx,
             if (!vals) {
                 ldap_get_option(sh->ldap, LDAP_OPT_RESULT_CODE, &lerrno);
                 if (lerrno != LDAP_SUCCESS) {
-                    DEBUG(SSSDBG_CRIT_FAILURE, "LDAP Library error: %d(%s)",
+                    DEBUG(SSSDBG_CRIT_FAILURE, "LDAP Library error: %d(%s)\n",
                           lerrno, sss_ldap_err2string(lerrno));
                     ret = EIO;
                     goto done;
@@ -517,7 +517,7 @@ int sdap_parse_entry(TALLOC_CTX *memctx,
 
     ldap_get_option(sh->ldap, LDAP_OPT_RESULT_CODE, &lerrno);
     if (lerrno) {
-        DEBUG(SSSDBG_CRIT_FAILURE, "LDAP Library error: %d(%s)",
+        DEBUG(SSSDBG_CRIT_FAILURE, "LDAP Library error: %d(%s)\n",
               lerrno, sss_ldap_err2string(lerrno));
         ret = EIO;
         goto done;
diff --git a/src/providers/ldap/sdap_async.c b/src/providers/ldap/sdap_async.c
index a6954620b..c30a4578e 100644
--- a/src/providers/ldap/sdap_async.c
+++ b/src/providers/ldap/sdap_async.c
@@ -1481,7 +1481,7 @@ static void sdap_get_generic_op_finished(struct sdap_op *op,
                                                &total_count, &cookie);
         ldap_controls_free(returned_controls);
         if (lret != LDAP_SUCCESS) {
-            DEBUG(SSSDBG_CRIT_FAILURE, "Could not determine page control");
+            DEBUG(SSSDBG_CRIT_FAILURE, "Could not determine page control\n");
             tevent_req_error(req, EIO);
             return;
         }
diff --git a/src/providers/ldap/sdap_async_connection.c b/src/providers/ldap/sdap_async_connection.c
index 304505458..bc03a87a2 100644
--- a/src/providers/ldap/sdap_async_connection.c
+++ b/src/providers/ldap/sdap_async_connection.c
@@ -1792,7 +1792,7 @@ static void sdap_cli_auth_step(struct tevent_req *req)
         ret = sdap_cli_auth_reconnect(req);
         if (ret != EOK) {
             DEBUG(SSSDBG_MINOR_FAILURE,
-                  "sdap_cli_auth_reconnect failed: %d:[%s]",
+                  "sdap_cli_auth_reconnect failed: %d:[%s]\n",
                   ret, sss_strerror(ret));
             tevent_req_error(req, ret);
         }
diff --git a/src/providers/ldap/sdap_async_initgroups.c b/src/providers/ldap/sdap_async_initgroups.c
index bc6b5e45e..2fd235f28 100644
--- a/src/providers/ldap/sdap_async_initgroups.c
+++ b/src/providers/ldap/sdap_async_initgroups.c
@@ -1792,7 +1792,7 @@ static void sdap_initgr_rfc2307bis_done(struct tevent_req *subreq)
     ret = save_rfc2307bis_groups(state);
     if (ret != EOK) {
         DEBUG(SSSDBG_MINOR_FAILURE,
-              "Could not save groups memberships [%d]", ret);
+              "Could not save groups memberships [%d]\n", ret);
         goto fail;
     }
 
@@ -1800,7 +1800,7 @@ static void sdap_initgr_rfc2307bis_done(struct tevent_req *subreq)
     ret = save_rfc2307bis_group_memberships(state);
     if (ret != EOK) {
         DEBUG(SSSDBG_MINOR_FAILURE,
-              "Could not save group memberships [%d]", ret);
+              "Could not save group memberships [%d]\n", ret);
         goto fail;
     }
 
@@ -1808,7 +1808,7 @@ static void sdap_initgr_rfc2307bis_done(struct tevent_req *subreq)
     ret = save_rfc2307bis_user_memberships(state);
     if (ret != EOK) {
         DEBUG(SSSDBG_MINOR_FAILURE,
-              "Could not save user memberships [%d]", ret);
+              "Could not save user memberships [%d]\n", ret);
         goto fail;
     }
 
diff --git a/src/providers/ldap/sdap_utils.c b/src/providers/ldap/sdap_utils.c
index 93a1faae1..f5ce8ee54 100644
--- a/src/providers/ldap/sdap_utils.c
+++ b/src/providers/ldap/sdap_utils.c
@@ -86,7 +86,7 @@ sdap_save_all_names(const char *name,
     ret = sysdb_attrs_get_aliases(tmp_ctx, ldap_attrs, name,
                                   lowercase, &aliases);
     if (ret != EOK) {
-        DEBUG(SSSDBG_OP_FAILURE, "Failed to get the alias list");
+        DEBUG(SSSDBG_OP_FAILURE, "Failed to get the alias list\n");
         goto done;
     }